SuperblocksHQ / ethereum-studio

Official Ethereum Studio project repository. And IDE specially tailored to make it as simple as possible to onboard new users into the Ethereum ecosystem
https://ethereum.org/build/
GNU General Public License v3.0
187 stars 103 forks source link

Move env variables to server side #184

Closed Spejbl closed 4 years ago

Spejbl commented 4 years ago

Description of the Change

Moves env variables from front-end to server side into CI/CD Platform and injects them into window object from which one we can easily use them

Alternate Designs

None

Benefits

Reduces the accessibility of env variables in front-end repository

Possible Drawbacks

ENV Variables won't be available inside process.env.${ENV_NAME} object anymore. You can access them from window.ENV.${ENV_NAME}

Verification Process

Testing Local env

  1. npm start should be functional as before without any noticeable issues

Testing Staging/Production - will be possible after merging this PR

Github Issues

NaN