search

SuperblocksHQ / ethereum-studio

Official Ethereum Studio project repository. And IDE specially tailored to make it as simple as possible to onboard new users into the Ethereum ecosystem
https://ethereum.org/build/
GNU General Public License v3.0
187 stars 103 forks source link

Moved template README images to use the ones from the static folder #189

Closed javier-tarazaga closed 4 years ago

javier-tarazaga commented 4 years ago

Description of the Change

Change from where images from the README file are being loaded. Atm they are broken and should be served from the static site's folder.

Github Issues

This fixes #183

samajammin commented 4 years ago

Thanks @javier-tarazaga! Anything I can do to review/test this & get it merged?

javier-tarazaga commented 4 years ago

@samajammin if you start the project locally and see it working

ChrisChinchilla commented 4 years ago

Odd, when did that change 🤔

samajammin commented 4 years ago

I'm having trouble getting my local env running (I'll create an issue if this persists) - @Spejbl could you please quickly review this & merge if it's working? Thanks!

samajammin commented 4 years ago

Fixed my local env issues but @javier-tarazaga when I started the project locally (via npm start), the READMES in the UI are out of date (they still link to /images/ dir & as a result are still broken):

Image 2020-02-05 at 10 38 55 AM

Is there a build step I'm missing to update the README files in the UI? I tried running npm run build then npm start but that didn't change anything.

javier-tarazaga commented 4 years ago

@samajammin sounds like a good idea in fact. We should not have to explain the UX of the tool in the readmes of the templates