SuperblocksHQ / ethereum-studio

Official Ethereum Studio project repository. And IDE specially tailored to make it as simple as possible to onboard new users into the Ethereum ecosystem
https://ethereum.org/build/
GNU General Public License v3.0
186 stars 103 forks source link

Update accountSelector component #208

Closed samajammin closed 4 years ago

samajammin commented 4 years ago

Summary

A couple items to simplify & improve the UX of this component

Motivation

Describe alternatives you've considered

Instead of removing the "configure account" screen, we could just remove the "Configure the account for each network" section but I think it'd be a nice simplification to remove this modal entirely.

Additional context

samajammin commented 4 years ago

@lovrobiljeskovic nice work removing the "configure account" screen but clicking outside of the menu still doesn't close it - any way we can fix that?

samajammin commented 4 years ago

Confirming this is still an issue.

Spejbl commented 4 years ago

Hey @samajammin this was because of the issue mentioned by Lovro, that it wasn't closing only when clicking on the iframe - the browser preview, as it doesn't have the same listeners as the main application. Only way I could think of solving this, was to wrap a fixed component around it. So it's more like a modal now. Would you mind to check out the PR for that? #247 Thanks