search

SuperblocksHQ / ethereum-studio

Official Ethereum Studio project repository. And IDE specially tailored to make it as simple as possible to onboard new users into the Ethereum ecosystem
https://ethereum.org/build/
GNU General Public License v3.0
186 stars 103 forks source link

Hide UI inputs until contract is deployed #228

Open samajammin opened 4 years ago

samajammin commented 4 years ago

Summary

We should hide all inputs from the browser UI until a contract has actually been deployed.

Motivation

Currently if a user attempts to interact with the UI before deploying the contract, the loader spins indefinitely (for Hello World template: https://share.getcloudapp.com/DOuQwYbj) or the input does nothing (for Coin & CryptoPizza templates). This could create a potentially confusing interaction for the user.

Describe alternatives you've considered

None

Additional context

None

nathan-lapinski commented 4 years ago

@samajammin Do you know if anyone has picked this up yet? For starters, I was going to update app.js in the Hello World template to be more defensive about accessing methods off of this.instance. I'd be happy to try to write a PR to hold off on rendering UI inputs until the contract has been deployed as well.

samajammin commented 4 years ago

@nathan-lapinski PRs definitely welcome! Thank you for offering!

nathan-lapinski commented 4 years ago

@samajammin Thank you for the opportunity to contribute! I'll start looking into it this evening, and add a PR once it is ready.

javier-tarazaga commented 4 years ago

Thanks @nathan-lapinski for the help :)

Looking forward to that PR!