Fix: Clicking outside of dropdown/menu should exit this component - Githubissues

SuperblocksHQ / ethereum-studio

Official Ethereum Studio project repository. And IDE specially tailored to make it as simple as possible to onboard new users into the Ethereum ecosystem

https://ethereum.org/build/

GNU General Public License v3.0

186 stars 103 forks source link

Fix: Clicking outside of dropdown/menu should exit this component #247

Closed Spejbl closed 4 years ago

Spejbl commented 4 years ago

Description of the Change

This should fix the issue when clicking outside of the account selector component it wouldn't hide the component. It was working correctly, only problem was when clicking on the iframe - (browser preview) - it wouldn't hide it.

Possible Drawbacks

Because the issue was due to the iframe, which doesn't have onClick events, I had to make the dropdown similar to modal. Meaning that there is now a wrapper component around it. So the drawback is that when clicking outside on the first click, it won't trigger the events, if any, it will just hide the account selector component.

Verification Process

Click on Account selector
Click anywhere but the account selector
It should hide the component