SuperblocksHQ / ethereum-studio

Official Ethereum Studio project repository. And IDE specially tailored to make it as simple as possible to onboard new users into the Ethereum ecosystem
https://ethereum.org/build/
GNU General Public License v3.0
186 stars 103 forks source link

Use modern JS in app.js of project templates #251

Open samajammin opened 4 years ago

samajammin commented 4 years ago

Summary

Refactor app.js files to use modern syntax - const/let vs. var & async/await.

Motivation

Describe alternatives you've considered

Additional context

nathan-lapinski commented 4 years ago

Hey @samajammin , are you accepting PRs for either of this or #243 ? If so, I'd be happy to try submitting a PR using either approach.

I think I could make pretty quick work of updating the templates to use React, if that's a library that you all would be happy with using.

I'd also be happy to just start out by updating the app.js files to use more modern JS syntax, now that #228 #207 are just about done.

samajammin commented 4 years ago

Thanks again @nathan-lapinski! I believe the team would welcome additional PRs 😄

I think I could make pretty quick work of updating the templates to use React, if that's a library that you all would be happy with using.

That's certainly our vision (see #243). If you think it'd be quick work, I'd say go for it! Otherwise I think this issue to update to more modern JS would be a great start.

javier-tarazaga commented 4 years ago

Hi @nathan-lapinski!

All contributions are always more than welcome :) Originally we thought of that implementation as codesanbox/stackblitz do it, by adding support to npm packages in the FE. Said this, this can be a draconian task to do. Any other way which can get us one step closer to support any FE frameworks like React, Vue, Angular, etc is always more than welcomed.

nathan-lapinski commented 4 years ago

Thanks @samajammin @javier-tarazaga !! I will start to look into this. I might just start with updating the app.js files to use more modern JS, since that should be a relatively quick win, and would be independent of any framework.

After that, I'd definitely like to look into #243 more 😄