search

SuperblocksHQ / ethereum-studio

Official Ethereum Studio project repository. And IDE specially tailored to make it as simple as possible to onboard new users into the Ethereum ecosystem
https://ethereum.org/build/
GNU General Public License v3.0
187 stars 103 forks source link

studio.ethereum.org should stop using window.web3 #275

Open samajammin opened 4 years ago

samajammin commented 4 years ago

From @remarks (thanks for reporting) in https://github.com/ethereum/ethereum-org-website/issues/1904:

This is not a bug yet, but the MetaMask team has noticed that studio.ethereum.org makes use of our injected window.web3 object. As described in MetaMask/metamask-extension#8077, we are going to stop injecting this object in the immediate future. If the website relies on this object to function, it will break for MetaMask users unless it migrates per our migration guide.

Specifically, we've detected usage of web3.eth.accounts. This could simply be replaced with await ethereum.request({ method: 'eth_accounts' }).

Of course, any script running on the website could be responsible for the accesses, but I recommend taking a look on your end.