search

Supercraft888 / lFinder

An open source command line interface link checker that will look for dead links. Made for DPS909 for release 0.1
ISC License
1 stars 4 forks source link

Add more details to your readme files #8

Open phast184 opened 4 years ago

phast184 commented 4 years ago

lineWithURLArray = lineArray.filter(line => line.includes("https:") || line.includes("http:") || line.includes("HTTPS:") || line.includes("HTTP:"));

Line 46, you want to find which line contains the URL by checking if that line includes "http", "https", "HTTP", "HTTPS". However, if that line contains only "https" which is not a valid URL, the result would be wrong.

Supercraft888 commented 4 years ago

Good catch! I'll change it so that it includes the :// after