search

Supergiovane / node-red-contrib-hikvision-ultimate

A native set of node for Hikvision Cameras, Doorbells, Alarms, Radars etc.
https://www.facebook.com/supergiovaneDev
MIT License
46 stars 12 forks source link

Make IP label clearer #29

Closed hepcat72 closed 2 years ago

hepcat72 commented 2 years ago

From a noob standpoint, there's no documentation on how to set the config node, but there are inferences to a DVR-type server, as if the camera is a part of a system that has a central server where recordings are stored, which makes a noob question what should go in the IP field, especially if they've made a config mistake somewhere that prevents a successful connection to the camera. So I thought changing "Server IP" to "Camera IP" might be just enough to assure a noob like me that they are correctly configuring the config node.

If this is inappropriate in other contexts, then a section in the readme explaining how to set up the config node might be helpful.

Supergiovane commented 2 years ago

Hi Thank you for the pull request. “Camera IP” cannot be correct as well, because the node can connect to nvr/camera etc.. It should be better if you can add the explanation of the “server” node in the Readme, bexause you’re right, there is no explanation on how configure it!

hepcat72 commented 2 years ago

Yeah, I figured. Thanks for creating this node.