Volume of players added as "Additional players" gets not set to specified one

Supergiovane / node-red-contrib-sonospollytts

Play speech TTS using Sonos.

https://www.facebook.com/supergiovaneDev

MIT License

12 stars 6 forks source link

Volume of players added as "Additional players" gets not set to specified one #48

Closed JorinL closed 3 years ago

JorinL commented 3 years ago

Hey there :-)

There has been a nice further development here :-) I'm glad to see that.

I noticed that the players under "Additional Player" do not get the volume value that is set under "Sonos Volume" - they therefore play at the volume that was previously used. That's at least the case with me

Player on 192.168.0.54 is not playing on Volume 30.

Supergiovane commented 3 years ago

Hi Jorin unfortunately, i haven't any additional player in my home to test this issue, because i use only a Connect-AMP with multiroom speakers. I'll check that. Maybe i send you a modified js file to test. Stay tuned.

Supergiovane commented 3 years ago

Hi Jorin Found the issue. The group volume is set after the play has been started, so the volume doesn't change until next play. I'm working on a fix.

Supergiovane commented 3 years ago

Hi Jorin Are you able to unzip and replace the unzipped file in the .node-red/nodes/node-red-contrib-sonospollytts/sonospollytts folder, restart node-red try again and let me know? sonospollytts.js.zip

JorinL commented 3 years ago

Yes give me some time - I'll test it :-)

JorinL commented 3 years ago

So I tested.

It is not really working. My Sets get muted and play or play the sound and are muted after.... Something seems to be wrong ;-)

Tested with volume 10.

Test 1: All speakers are unmuted 1 volume before muted - expecting them to gain to 10. Playing = all muted - no sound

Test 2: Setting them up as a big group Playing = all muted - manually setting volume up sound is hearable.

Supergiovane commented 3 years ago

Mmmmmm... I saw that auto discovery doesn’t work for you. In fact, you see all IP addresses instead of the device names. Are you using node-red behind something? Maybe redmatic or behind a natted docker?

JorinL commented 3 years ago

I have running a rancher kubernetes cluster inside that it's all running.

Supergiovane commented 3 years ago

I suspect that some api calls, wont pass through the natting. I’ll try tomorrow another approach, just for you. Good night.

JorinL commented 3 years ago

Would be nice :-) Good night!

Supergiovane commented 3 years ago

Hi Jorin. Can you try this file, please? Unzip and place as before. sonospollytts.js.zip

JorinL commented 3 years ago

Works like charm! :-) Thank you!!

Different question: When deploying the flow sonospollytts stops all playback - is that needed? Should I open another issue for that? It is.... a bit... annoying ;-)

Supergiovane commented 3 years ago

Hi Jorin Good. I'll publish an official update in the next hours. And... yes, if you deploy, it stops. That's a normal behaviour because whenever you deploy a node, node-red re-initializes the startup sequence, thus loosing the connection with the sonos. Sorry, i cannot change this behaviour.

JorinL commented 3 years ago

Thank you :-)