Supergiovane / node-red-contrib-tts-ultimate

This node transforms a text into a speech audio. You can hear the voice natively through Sonos or external players.
MIT License
22 stars 5 forks source link

Main Sonos Player Dropdown Displays Speakers as a Group #65

Closed kars85 closed 1 year ago

kars85 commented 1 year ago

Hello!

Describe the bug I've noticed inconsistent behavior with the menu drop down for speaker selection. My main player has a static reservation on my router outside of my DHCP scope, FWIW. However, the drop down "bundles" that main player with my other speakers sometimes. These other speakers are not static IP'd.

To Reproduce Unknown and the issue isn't clear on how to reproduce - I've restarted the docker nodered container but can't get the Main Sonos player drop down, or the dropdown under additional players to list out the grouped speakers individually

Expected behavior I'm thinking the expected behavior is to not have the drop down display speaker groups, and instead have them listed out individually?

Screenshots image

TTS-Ultimate Version 1.0.52

Are you running node-red behind homematic, docker or anything similar? Docker in host networking mode

Supergiovane commented 1 year ago

Hi it list all sonos speaker connected to the lan. You can choose whatever you want. This is an intended behavior. :-)

kars85 commented 1 year ago

Thanks for the reply! I think the confusion is highlighted in the picture. The Kitchen Sonos +2 is not intended as it's hiding the Master Bedroom Sonos and Shop Sonos, and instead, grouping them together. I don't want to broadcast to those devices.

Supergiovane commented 1 year ago

Hi Kars Understood. I’ll try to reply that and find a way to show the single sonos speakers… I’ll let you know asap…

Supergiovane commented 1 year ago

Hi Kars Fixed in 1.0.53. You should see it in the palette in about 1 hour.

kars85 commented 1 year ago

Hi @Supergiovane - apologies if reopening is not preferred, and instead you'd like a different issue opened up. I had a chance to look at the updated palette, and am noticing to different issues. Instead of any grouping as shown in my first screenshot above, now the dropdown list shows duplicate speaker entries for any speaker that doesn't have a static DHCP reservation.

Not being fluent in how the palette leverages Sonos' API, I wanted to lay out some assumptions:

1) If I had a group of speakers combined during normal music listening, could have that been why the palette presented them in a group in my initial screenshot? 1a) If so, could you build a condition into the palette where it only separates the speaker group out if detected?

2) Now it seems like the only speaker not duplicated in the drop down is my "master" that has a DHCP reservation tied to it.

image

Supergiovane commented 1 year ago

Hi currently, it's a little difficult to determine whether a sonos player is part of a group or not, so you see many duplicates. I'm looking on that, to be able at least to filter out duplicate IPs.

Supergiovane commented 1 year ago

node-red-contrib-tts-ultimate@1.0.55 is out with de-duplication function. Currently, this is at best, what i can do.