Open Rowantale opened 4 months ago
I'm guessing this is because I use the velocity parameters to determine the size of the explosion particles because I didn't know any better way at the time. I do know of a proper way to add custom parameters to the particles now, and I'm guessing that might fix this. However, it'll have to wait until at least next week.
Is this an urgent issue for you and your map? I plan on changing a lot on the back end of this mod soon-ish but I can try to look into this before that if it is important for you and your map.
It's not urgent no, I'm in 1.21 and I kinda forgot they added wind charges which are exactly what I'm using it for haha
Would like to up this issue, as this is commonly used by server side mods, eg polyfactory, and personal ones, to accelerate the player, but keep movement control
At https://github.com/Superkat32/Explosive-Enhancement/blob/c70b767157273857eb794ac01bb37bd425c5da57/src/main/java/net/superkat/explosiveenhancement/mixin/ExplosionMixin.java#L35 you should be able to do && power >= 0 (Maybe > 0)
Would like to up this issue, as this is commonly used by server side mods, eg polyfactory, and personal ones, to accelerate the player, but keep movement control
I will keep this in mind and try to move it higher on my todo list, but it'll still take me time as I want to finish another mod first, then I'll see if I can get to this. I want to merge this bug fix with a few other major changes, which will take time.
I'm using negative explosions as a means to control damage in a PvP/adventure map, and I've found that this mod causes a "/ by zero" arithmetic error which kicks me from worlds, multiplayer and singleplayer.
I'm not 100% sure if it is just negative explosions, because it's not 100% consistent. But, I haven't experienced this issue with normal explosions, and turning off dynamic size fixes it. It seems semi-replicable with the following command:
/summon minecraft:fireball ~ ~1 ~ {ExplosionPower:-2b,Motion:[-1d,-1d,0d]}
Multiplayer disconnect log:
[disconnect-2024-06-17_12.59.34-client - multiplayer.txt](https://github.com/user-attachments/files/15875500/disconnect-2024-06-17_12.59.34-client.-.multiplayer.txt) ---- Minecraft Network Protocol Error Report ---- // Don't worry, I'll be fine Time: 2024-06-17 12:59:34 Description: Exception while adding particle java.lang.ArithmeticException: / by zero at net.minecraft.class_702$class_4090.method_18138(class_702.java:104) at net.fabricmc.fabric.impl.client.particle.FabricSpriteProviderImpl.method_18138(FabricSpriteProviderImpl.java:51) at net.minecraft.class_4003.method_18142(class_4003.java:47) at net.superkat.explosiveenhancement.particles.SmokeParticle.Singleplayer disconnect log:
[disconnect-2024-06-17_13.26.07-client - singleplayer.txt](https://github.com/user-attachments/files/15875501/disconnect-2024-06-17_13.26.07-client.-.singleplayer.txt) ---- Minecraft Network Protocol Error Report ---- // Could be worse, I guess Time: 2024-06-17 13:26:07 Description: Exception while adding particle java.lang.ArithmeticException: / by zero at net.minecraft.class_702$class_4090.method_18138(class_702.java:104) at net.fabricmc.fabric.impl.client.particle.FabricSpriteProviderImpl.method_18138(FabricSpriteProviderImpl.java:51) at net.minecraft.class_4003.method_18142(class_4003.java:47) at net.superkat.explosiveenhancement.particles.SmokeParticle.(edited to include logs in a dropdown as well as raw file)