Superkat32 / Explosive-Enhancement

Enhancing the explosion animation since 2023
https://modrinth.com/mod/explosive-enhancement
MIT License
12 stars 5 forks source link

Connection error, seems to be when rendering negative explosions #35

Open Rowantale opened 4 months ago

Rowantale commented 4 months ago

I'm using negative explosions as a means to control damage in a PvP/adventure map, and I've found that this mod causes a "/ by zero" arithmetic error which kicks me from worlds, multiplayer and singleplayer.

I'm not 100% sure if it is just negative explosions, because it's not 100% consistent. But, I haven't experienced this issue with normal explosions, and turning off dynamic size fixes it. It seems semi-replicable with the following command:

/summon minecraft:fireball ~ ~1 ~ {ExplosionPower:-2b,Motion:[-1d,-1d,0d]}


Multiplayer disconnect log: [disconnect-2024-06-17_12.59.34-client - multiplayer.txt](https://github.com/user-attachments/files/15875500/disconnect-2024-06-17_12.59.34-client.-.multiplayer.txt) ---- Minecraft Network Protocol Error Report ---- // Don't worry, I'll be fine Time: 2024-06-17 12:59:34 Description: Exception while adding particle java.lang.ArithmeticException: / by zero at net.minecraft.class_702$class_4090.method_18138(class_702.java:104) at net.fabricmc.fabric.impl.client.particle.FabricSpriteProviderImpl.method_18138(FabricSpriteProviderImpl.java:51) at net.minecraft.class_4003.method_18142(class_4003.java:47) at net.superkat.explosiveenhancement.particles.SmokeParticle.(SmokeParticle.java:43) at net.superkat.explosiveenhancement.particles.SmokeParticle$Factory.createParticle(SmokeParticle.java:88) at net.superkat.explosiveenhancement.particles.SmokeParticle$Factory.method_3090(SmokeParticle.java:79) at net.minecraft.class_702.method_3055(class_702.java:362) at net.minecraft.class_702.method_3056(class_702.java:347) at net.minecraft.class_761.method_3288(class_761.java:2495) at net.minecraft.class_761.method_8563(class_761.java:2455) at net.minecraft.class_761.method_8568(class_761.java:2450) at net.minecraft.class_638.method_8466(class_638.java:618) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnExplosionParticles(ExplosiveHandler.java:104) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnParticles(ExplosiveHandler.java:33) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:57) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:39) at net.minecraft.class_1927.handler$zlm000$explosiveenhancement$spawnExplosiveParticles(class_1927.java:536) at net.minecraft.class_1927.method_8350(class_1927.java:281) at net.minecraft.class_634.method_11124(class_634.java:1200) at net.minecraft.class_2664.method_11480(class_2664.java:121) at net.minecraft.class_2664.method_11054(class_2664.java:20) at net.minecraft.class_2600.method_11072(class_2600.java:27) at net.minecraft.class_1255.method_18859(class_1255.java:162) at net.minecraft.class_4093.method_18859(class_4093.java:23) at net.minecraft.class_1255.method_16075(class_1255.java:136) at net.minecraft.class_1255.method_5383(class_1255.java:121) at net.minecraft.class_310.method_1523(class_310.java:1240) at net.minecraft.class_310.method_1514(class_310.java:882) at net.minecraft.client.main.Main.main(Main.java:256) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Stacktrace: at net.minecraft.class_702$class_4090.method_18138(class_702.java:104) at net.fabricmc.fabric.impl.client.particle.FabricSpriteProviderImpl.method_18138(FabricSpriteProviderImpl.java:51) at net.minecraft.class_4003.method_18142(class_4003.java:47) at net.superkat.explosiveenhancement.particles.SmokeParticle.(SmokeParticle.java:43) at net.superkat.explosiveenhancement.particles.SmokeParticle$Factory.createParticle(SmokeParticle.java:88) at net.superkat.explosiveenhancement.particles.SmokeParticle$Factory.method_3090(SmokeParticle.java:79) at net.minecraft.class_702.method_3055(class_702.java:362) at net.minecraft.class_702.method_3056(class_702.java:347) at net.minecraft.class_761.method_3288(class_761.java:2495) at net.minecraft.class_761.method_8563(class_761.java:2455) at net.minecraft.class_761.method_8568(class_761.java:2450) at net.minecraft.class_638.method_8466(class_638.java:618) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnExplosionParticles(ExplosiveHandler.java:104) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnParticles(ExplosiveHandler.java:33) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:57) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:39) at net.minecraft.class_1927.handler$zlm000$explosiveenhancement$spawnExplosiveParticles(class_1927.java:536) at net.minecraft.class_1927.method_8350(class_1927.java:281) -- Particle being added -- Details: ID: explosiveenhancement:smoke Parameters: DataResult.Success[{type:"explosiveenhancement:smoke"}] Position: -75.27,-59.80,-39.88 - World: (-76,-60,-40), Section: (at 4,4,8 in -5,-4,-3; chunk contains blocks -80,-64,-48 to -65,319,-33), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1) Stacktrace: at net.minecraft.class_761.method_8563(class_761.java:2455) at net.minecraft.class_761.method_8568(class_761.java:2450) at net.minecraft.class_638.method_8466(class_638.java:618) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnExplosionParticles(ExplosiveHandler.java:104) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnParticles(ExplosiveHandler.java:33) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:57) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:39) at net.minecraft.class_1927.handler$zlm000$explosiveenhancement$spawnExplosiveParticles(class_1927.java:536) at net.minecraft.class_1927.method_8350(class_1927.java:281) at net.minecraft.class_634.method_11124(class_634.java:1200) at net.minecraft.class_2664.method_11480(class_2664.java:121) at net.minecraft.class_2664.method_11054(class_2664.java:20) at net.minecraft.class_2600.method_11072(class_2600.java:27) at net.minecraft.class_1255.method_18859(class_1255.java:162) at net.minecraft.class_4093.method_18859(class_4093.java:23) at net.minecraft.class_1255.method_16075(class_1255.java:136) at net.minecraft.class_1255.method_5383(class_1255.java:121) at net.minecraft.class_310.method_1523(class_310.java:1240) at net.minecraft.class_310.method_1514(class_310.java:882) at net.minecraft.client.main.Main.main(Main.java:256) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) -- Incoming Packet -- Details: Type: clientbound/minecraft:explode Is Terminal: false Is Skippable: false Stacktrace: at net.minecraft.class_2600.method_59803(class_2600.java:56) at net.minecraft.class_8673.method_60882(class_8673.java:136) at net.minecraft.class_8673.method_59807(class_8673.java:113) at net.minecraft.class_2600.method_11072(class_2600.java:32) at net.minecraft.class_1255.method_18859(class_1255.java:162) at net.minecraft.class_4093.method_18859(class_4093.java:23) at net.minecraft.class_1255.method_16075(class_1255.java:136) at net.minecraft.class_1255.method_5383(class_1255.java:121) at net.minecraft.class_310.method_1523(class_310.java:1240) at net.minecraft.class_310.method_1514(class_310.java:882) at net.minecraft.client.main.Main.main(Main.java:256) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) -- Connection -- Details: Protocol: play Flow: CLIENTBOUND Server type: OTHER Server brand: vanilla -- System Details -- Details: Minecraft Version: 1.21 Minecraft Version ID: 1.21 Operating System: Windows 10 (amd64) version 10.0 Java Version: 22.0.1, Oracle Corporation Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation Memory: 246165256 bytes (234 MiB) / 987758592 bytes (942 MiB) up to 4294967296 bytes (4096 MiB) CPUs: 16 Processor Vendor: AuthenticAMD Processor Name: AMD Ryzen 7 3700X 8-Core Processor Identifier: AuthenticAMD Family 23 Model 113 Stepping 0 Microarchitecture: Zen 2 Frequency (GHz): 4.05 Number of physical packages: 1 Number of physical CPUs: 8 Number of logical CPUs: 16 Graphics card #0 name: NVIDIA GeForce GTX 1070 Ti Graphics card #0 vendor: NVIDIA Graphics card #0 VRAM (MiB): 8192.00 Graphics card #0 deviceId: VideoController1 Graphics card #0 versionInfo: 31.0.15.5212 Memory slot #0 capacity (MiB): 8192.00 Memory slot #0 clockSpeed (GHz): 2.13 Memory slot #0 type: DDR4 Memory slot #1 capacity (MiB): 8192.00 Memory slot #1 clockSpeed (GHz): 2.13 Memory slot #1 type: DDR4 Virtual memory max (MiB): 28096.46 Virtual memory used (MiB): 15859.89 Swap memory total (MiB): 11776.00 Swap memory used (MiB): 124.10 Space in storage for jna.tmpdir (MiB): Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB): Space in storage for io.netty.native.workdir (MiB): Space in storage for java.io.tmpdir (MiB): available: 54014.35, total: 475915.94 Space in storage for workdir (MiB): available: 54014.35, total: 475915.94 JVM Flags: 7 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx4096m Fabric Mods: appleskin: AppleSkin 3.0.2+mc1.21 cloth-config: Cloth Config v15 15.0.127 cloth-basic-math: cloth-basic-math 0.6.1 c2me: Concurrent Chunk Management Engine 0.2.0+alpha.11.100+1.21 c2me-base: Concurrent Chunk Management Engine (Base) 0.2.0+alpha.11.100+1.21 c2me-client-uncapvd: Concurrent Chunk Management Engine (Client/Uncap View Distance) 0.2.0+alpha.11.100+1.21 c2me-fixes-chunkio-threading-issues: Concurrent Chunk Management Engine (Fixes/Chunk IO/Threading Issues) 0.2.0+alpha.11.100+1.21 c2me-fixes-general-threading-issues: Concurrent Chunk Management Engine (Fixes/General/Threading Issues) 0.2.0+alpha.11.100+1.21 c2me-fixes-worldgen-threading-issues: Concurrent Chunk Management Engine (Fixes/WorldGen/Threading Issues) 0.2.0+alpha.11.100+1.21 c2me-fixes-worldgen-vanilla-bugs: Concurrent Chunk Management Engine (Fixes/WorldGen/Vanilla Bugs) 0.2.0+alpha.11.100+1.21 c2me-notickvd: Concurrent Chunk Management Engine (No Tick View Distance) 0.2.0+alpha.11.100+1.21 c2me-opts-allocs: Concurrent Chunk Management Engine (Optimizations/Memory Allocations) 0.2.0+alpha.11.100+1.21 c2me-opts-chunk-access: Concurrent Chunk Management Engine (Optimizations/Chunk Access) 0.2.0+alpha.11.100+1.21 c2me-opts-chunkio: Concurrent Chunk Management Engine (Optimizations/Chunk IO) 0.2.0+alpha.11.100+1.21 c2me-opts-math: Concurrent Chunk Management Engine (Optimizations/Math) 0.2.0+alpha.11.100+1.21 c2me-opts-scheduling: Concurrent Chunk Management Engine (Optimizations/Scheduling) 0.2.0+alpha.11.100+1.21 c2me-opts-worldgen-general: Concurrent Chunk Management Engine (Optimizations/General WorldGen) 0.2.0+alpha.11.100+1.21 c2me-opts-worldgen-vanilla: Concurrent Chunk Management Engine (Optimizations/Vanilla WorldGen) 0.2.0+alpha.11.100+1.21 c2me-rewrites-chunk-serializer: Concurrent Chunk Management Engine (Rewrites/Chunk Serializer) 0.2.0+alpha.11.100+1.21 c2me-rewrites-chunkio: Concurrent Chunk Management Engine (Rewrites/Chunk IO) 0.2.0+alpha.11.100+1.21 c2me-server-utils: Concurrent Chunk Management Engine (Server Utils) 0.2.0+alpha.11.100+1.21 c2me-threading-chunkio: Concurrent Chunk Management Engine (Threading/WorldGen) 0.2.0+alpha.11.100+1.21 c2me-threading-lighting: Concurrent Chunk Management Engine (Threading/Lighting) 0.2.0+alpha.11.100+1.21 c2me-threading-worldgen: Concurrent Chunk Management Engine (Threading/WorldGen) 0.2.0+alpha.11.100+1.21 com_electronwill_night-config_core: core 3.6.5 com_electronwill_night-config_toml: toml 3.6.5 com_ibm_async_asyncutil: asyncutil 0.1.0 net_objecthunter_exp4j: exp4j 0.4.8 org_threadly_threadly: threadly 7.0 collisionfix: CollisionFix 1.0.1 continuity: Continuity 3.0.0-beta.5+1.21 detailab: Detail Armor Bar 2.6.3+1.21-fabric dynamic_fps: Dynamic FPS 3.4.3 dynamiccrosshair: Dynamic Crosshair 8.0.1+1.21 dynamiccrosshair-api: DynamicCrosshair API ${api_version} libbamboo: libbamboo 1.21.0 entity_model_features: Entity Model Features 2.1 entity_texture_features: Entity Texture Features 6.1.1 org_apache_httpcomponents_httpmime: httpmime 4.5.10 entityculling: EntityCulling 1.6.6 explosiveenhancement: Explosive Enhancement 1.2.3-1.21.0 fabric-api: Fabric API 0.100.1+1.21 fabric-api-base: Fabric API Base 0.4.42+6573ed8c90 fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.65+b559734490 fabric-biome-api-v1: Fabric Biome API (v1) 13.0.28+6fc22b9990 fabric-block-api-v1: Fabric Block API (v1) 1.0.22+0af3f5a790 fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.10+6573ed8c90 fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.52+0af3f5a790 fabric-client-tags-api-v1: Fabric Client Tags 1.1.15+6573ed8c90 fabric-command-api-v1: Fabric Command API (v1) 1.2.48+f71b366f90 fabric-command-api-v2: Fabric Command API (v2) 2.2.27+6a6dfa1990 fabric-commands-v0: Fabric Commands (v0) 0.2.65+df3654b390 fabric-content-registries-v0: Fabric Content Registries (v0) 8.0.11+b559734490 fabric-convention-tags-v1: Fabric Convention Tags 2.0.12+7f945d5b90 fabric-convention-tags-v2: Fabric Convention Tags (v2) 2.2.1+d153f34490 fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.29+0af3f5a790 fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.1.22+6a6dfa1990 fabric-data-generation-api-v1: Fabric Data Generation API (v1) 20.2.6+16c4ae2590 fabric-dimensions-v1: Fabric Dimensions API (v1) 4.0.0+6fc22b9990 fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.12+6fc22b9990 fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.7.10+e633f88390 fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.52+6573ed8c90 fabric-item-api-v1: Fabric Item API (v1) 11.0.0+afdfc92190 fabric-item-group-api-v1: Fabric Item Group API (v1) 4.1.0+00ab0a6390 fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.47+0af3f5a790 fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.45+df3654b390 fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.3.9+98a7dbbb90 fabric-loot-api-v2: Fabric Loot API (v2) 3.0.9+6573ed8c90 fabric-message-api-v1: Fabric Message API (v1) 6.0.13+6573ed8c90 fabric-model-loading-api-v1: Fabric Model Loading API (v1) 2.0.0+fe474d6b90 fabric-networking-api-v1: Fabric Networking API (v1) 4.1.0+686dcdce90 fabric-object-builder-api-v1: Fabric Object Builder API (v1) 15.1.10+d132107690 fabric-particles-v1: Fabric Particles (v1) 4.0.2+6573ed8c90 fabric-recipe-api-v1: Fabric Recipe API (v1) 5.0.8+6573ed8c90 fabric-registry-sync-v0: Fabric Registry Sync (v0) 5.0.21+b9828ba390 fabric-renderer-api-v1: Fabric Renderer API (v1) 3.2.16+fe474d6b90 fabric-renderer-indigo: Fabric Renderer - Indigo 1.6.3+cc9f121a90 fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.66+df3654b390 fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.48+73761d2e90 fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.1.6+b559734490 fabric-rendering-v0: Fabric Rendering (v0) 1.1.69+df3654b390 fabric-rendering-v1: Fabric Rendering (v1) 5.0.3+d132107690 fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 4.2.1+d153f34490 fabric-resource-loader-v0: Fabric Resource Loader (v0) 1.1.3+b559734490 fabric-screen-api-v1: Fabric Screen API (v1) 2.0.24+b559734490 fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.78+b559734490 fabric-sound-api-v1: Fabric Sound API (v1) 1.0.23+6573ed8c90 fabric-transfer-api-v1: Fabric Transfer API (v1) 5.1.12+b559734490 fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 6.0.12+6573ed8c90 fabricloader: Fabric Loader 0.15.11 mixinextras: MixinExtras 0.3.5 fabricskyboxes: FabricSkyBoxes 0.7.4+mc1.21 ferritecore: FerriteCore 7.0.0 immediatelyfast: ImmediatelyFast 1.2.18+1.21 net_lenni0451_reflect: Reflect 1.3.4 indium: Indium 1.0.33+mc1.21 iris: Iris 1.7.1+mc1.21 io_github_douira_glsl-transformer: glsl-transformer 2.0.1 org_anarres_jcpp: jcpp 1.4.14 org_antlr_antlr4-runtime: antlr4-runtime 4.13.1 java: Java HotSpot(TM) 64-Bit Server VM 22 lithium: Lithium 0.12.5 minecraft: Minecraft 1.21 modernfix: ModernFix 5.18.2+mc1.21 modmenu: Mod Menu 11.0.0-rc.2 placeholder-api: Placeholder API 2.4.0-pre.2+1.21 notenoughanimations: NotEnoughAnimations 1.7.4 packetfixer: Packet Fixer 1.4.1 presencefootsteps: Presence Footsteps 1.10.0+1.21 kirin: Kirin UI 1.19.0+1.21 reeses-sodium-options: Reese's Sodium Options 1.7.2+mc1.21 sodium: Sodium 0.5.9+mc1.21 sodium-extra: Sodium Extra 0.5.7+mc1.21 caffeineconfig: CaffeineConfig 1.3.0+1.17 sound_physics_remastered: Sound Physics Remastered 1.21-1.4.3 Loaded Shaderpack: photon_v1.0a.zip Profile: Custom (+44 options changed by user)

Singleplayer disconnect log: [disconnect-2024-06-17_13.26.07-client - singleplayer.txt](https://github.com/user-attachments/files/15875501/disconnect-2024-06-17_13.26.07-client.-.singleplayer.txt) ---- Minecraft Network Protocol Error Report ---- // Could be worse, I guess Time: 2024-06-17 13:26:07 Description: Exception while adding particle java.lang.ArithmeticException: / by zero at net.minecraft.class_702$class_4090.method_18138(class_702.java:104) at net.fabricmc.fabric.impl.client.particle.FabricSpriteProviderImpl.method_18138(FabricSpriteProviderImpl.java:51) at net.minecraft.class_4003.method_18142(class_4003.java:47) at net.superkat.explosiveenhancement.particles.SmokeParticle.(SmokeParticle.java:43) at net.superkat.explosiveenhancement.particles.SmokeParticle$Factory.createParticle(SmokeParticle.java:88) at net.superkat.explosiveenhancement.particles.SmokeParticle$Factory.method_3090(SmokeParticle.java:79) at net.minecraft.class_702.method_3055(class_702.java:362) at net.minecraft.class_702.method_3056(class_702.java:347) at net.minecraft.class_761.method_3288(class_761.java:2495) at net.minecraft.class_761.method_8563(class_761.java:2455) at net.minecraft.class_761.method_8568(class_761.java:2450) at net.minecraft.class_638.method_8466(class_638.java:618) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnExplosionParticles(ExplosiveHandler.java:108) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnParticles(ExplosiveHandler.java:33) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:57) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:39) at net.minecraft.class_1927.handler$zlm000$explosiveenhancement$spawnExplosiveParticles(class_1927.java:536) at net.minecraft.class_1927.method_8350(class_1927.java:281) at net.minecraft.class_634.method_11124(class_634.java:1200) at net.minecraft.class_2664.method_11480(class_2664.java:121) at net.minecraft.class_2664.method_11054(class_2664.java:20) at net.minecraft.class_2600.method_11072(class_2600.java:27) at net.minecraft.class_1255.method_18859(class_1255.java:162) at net.minecraft.class_4093.method_18859(class_4093.java:23) at net.minecraft.class_1255.method_16075(class_1255.java:136) at net.minecraft.class_1255.method_5383(class_1255.java:121) at net.minecraft.class_310.method_1523(class_310.java:1240) at net.minecraft.class_310.method_1514(class_310.java:882) at net.minecraft.client.main.Main.main(Main.java:256) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Stacktrace: at net.minecraft.class_702$class_4090.method_18138(class_702.java:104) at net.fabricmc.fabric.impl.client.particle.FabricSpriteProviderImpl.method_18138(FabricSpriteProviderImpl.java:51) at net.minecraft.class_4003.method_18142(class_4003.java:47) at net.superkat.explosiveenhancement.particles.SmokeParticle.(SmokeParticle.java:43) at net.superkat.explosiveenhancement.particles.SmokeParticle$Factory.createParticle(SmokeParticle.java:88) at net.superkat.explosiveenhancement.particles.SmokeParticle$Factory.method_3090(SmokeParticle.java:79) at net.minecraft.class_702.method_3055(class_702.java:362) at net.minecraft.class_702.method_3056(class_702.java:347) at net.minecraft.class_761.method_3288(class_761.java:2495) at net.minecraft.class_761.method_8563(class_761.java:2455) at net.minecraft.class_761.method_8568(class_761.java:2450) at net.minecraft.class_638.method_8466(class_638.java:618) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnExplosionParticles(ExplosiveHandler.java:108) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnParticles(ExplosiveHandler.java:33) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:57) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:39) at net.minecraft.class_1927.handler$zlm000$explosiveenhancement$spawnExplosiveParticles(class_1927.java:536) at net.minecraft.class_1927.method_8350(class_1927.java:281) -- Particle being added -- Details: ID: explosiveenhancement:smoke Parameters: DataResult.Success[{type:"explosiveenhancement:smoke"}] Position: 31.17,-60.00,14.81 - World: (31,-60,14), Section: (at 15,4,14 in 1,-4,0; chunk contains blocks 16,-64,0 to 31,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511) Stacktrace: at net.minecraft.class_761.method_8563(class_761.java:2455) at net.minecraft.class_761.method_8568(class_761.java:2450) at net.minecraft.class_638.method_8466(class_638.java:618) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnExplosionParticles(ExplosiveHandler.java:108) at net.superkat.explosiveenhancement.ExplosiveHandler.spawnParticles(ExplosiveHandler.java:33) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:57) at net.superkat.explosiveenhancement.api.ExplosiveApi.spawnParticles(ExplosiveApi.java:39) at net.minecraft.class_1927.handler$zlm000$explosiveenhancement$spawnExplosiveParticles(class_1927.java:536) at net.minecraft.class_1927.method_8350(class_1927.java:281) at net.minecraft.class_634.method_11124(class_634.java:1200) at net.minecraft.class_2664.method_11480(class_2664.java:121) at net.minecraft.class_2664.method_11054(class_2664.java:20) at net.minecraft.class_2600.method_11072(class_2600.java:27) at net.minecraft.class_1255.method_18859(class_1255.java:162) at net.minecraft.class_4093.method_18859(class_4093.java:23) at net.minecraft.class_1255.method_16075(class_1255.java:136) at net.minecraft.class_1255.method_5383(class_1255.java:121) at net.minecraft.class_310.method_1523(class_310.java:1240) at net.minecraft.class_310.method_1514(class_310.java:882) at net.minecraft.client.main.Main.main(Main.java:256) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) -- Incoming Packet -- Details: Type: clientbound/minecraft:explode Is Terminal: false Is Skippable: false Stacktrace: at net.minecraft.class_2600.method_59803(class_2600.java:56) at net.minecraft.class_8673.method_60882(class_8673.java:136) at net.minecraft.class_8673.method_59807(class_8673.java:113) at net.minecraft.class_2600.method_11072(class_2600.java:32) at net.minecraft.class_1255.method_18859(class_1255.java:162) at net.minecraft.class_4093.method_18859(class_4093.java:23) at net.minecraft.class_1255.method_16075(class_1255.java:136) at net.minecraft.class_1255.method_5383(class_1255.java:121) at net.minecraft.class_310.method_1523(class_310.java:1240) at net.minecraft.class_310.method_1514(class_310.java:882) at net.minecraft.client.main.Main.main(Main.java:256) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) -- Connection -- Details: Protocol: play Flow: CLIENTBOUND Server type: Server brand: fabric -- System Details -- Details: Minecraft Version: 1.21 Minecraft Version ID: 1.21 Operating System: Windows 10 (amd64) version 10.0 Java Version: 22.0.1, Oracle Corporation Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation Memory: 215411312 bytes (205 MiB) / 1149239296 bytes (1096 MiB) up to 4294967296 bytes (4096 MiB) CPUs: 16 Processor Vendor: AuthenticAMD Processor Name: AMD Ryzen 7 3700X 8-Core Processor Identifier: AuthenticAMD Family 23 Model 113 Stepping 0 Microarchitecture: Zen 2 Frequency (GHz): 4.05 Number of physical packages: 1 Number of physical CPUs: 8 Number of logical CPUs: 16 Graphics card #0 name: NVIDIA GeForce GTX 1070 Ti Graphics card #0 vendor: NVIDIA Graphics card #0 VRAM (MiB): 8192.00 Graphics card #0 deviceId: VideoController1 Graphics card #0 versionInfo: 31.0.15.5212 Memory slot #0 capacity (MiB): 8192.00 Memory slot #0 clockSpeed (GHz): 2.13 Memory slot #0 type: DDR4 Memory slot #1 capacity (MiB): 8192.00 Memory slot #1 clockSpeed (GHz): 2.13 Memory slot #1 type: DDR4 Virtual memory max (MiB): 28096.46 Virtual memory used (MiB): 16874.59 Swap memory total (MiB): 11776.00 Swap memory used (MiB): 105.73 Space in storage for jna.tmpdir (MiB): Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB): Space in storage for io.netty.native.workdir (MiB): Space in storage for java.io.tmpdir (MiB): available: 54014.21, total: 475915.94 Space in storage for workdir (MiB): available: 54014.21, total: 475915.94 JVM Flags: 7 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms512m -Xmx4096m Fabric Mods: appleskin: AppleSkin 3.0.2+mc1.21 cloth-config: Cloth Config v15 15.0.127 cloth-basic-math: cloth-basic-math 0.6.1 c2me: Concurrent Chunk Management Engine 0.2.0+alpha.11.100+1.21 c2me-base: Concurrent Chunk Management Engine (Base) 0.2.0+alpha.11.100+1.21 c2me-client-uncapvd: Concurrent Chunk Management Engine (Client/Uncap View Distance) 0.2.0+alpha.11.100+1.21 c2me-fixes-chunkio-threading-issues: Concurrent Chunk Management Engine (Fixes/Chunk IO/Threading Issues) 0.2.0+alpha.11.100+1.21 c2me-fixes-general-threading-issues: Concurrent Chunk Management Engine (Fixes/General/Threading Issues) 0.2.0+alpha.11.100+1.21 c2me-fixes-worldgen-threading-issues: Concurrent Chunk Management Engine (Fixes/WorldGen/Threading Issues) 0.2.0+alpha.11.100+1.21 c2me-fixes-worldgen-vanilla-bugs: Concurrent Chunk Management Engine (Fixes/WorldGen/Vanilla Bugs) 0.2.0+alpha.11.100+1.21 c2me-notickvd: Concurrent Chunk Management Engine (No Tick View Distance) 0.2.0+alpha.11.100+1.21 c2me-opts-allocs: Concurrent Chunk Management Engine (Optimizations/Memory Allocations) 0.2.0+alpha.11.100+1.21 c2me-opts-chunk-access: Concurrent Chunk Management Engine (Optimizations/Chunk Access) 0.2.0+alpha.11.100+1.21 c2me-opts-chunkio: Concurrent Chunk Management Engine (Optimizations/Chunk IO) 0.2.0+alpha.11.100+1.21 c2me-opts-math: Concurrent Chunk Management Engine (Optimizations/Math) 0.2.0+alpha.11.100+1.21 c2me-opts-scheduling: Concurrent Chunk Management Engine (Optimizations/Scheduling) 0.2.0+alpha.11.100+1.21 c2me-opts-worldgen-general: Concurrent Chunk Management Engine (Optimizations/General WorldGen) 0.2.0+alpha.11.100+1.21 c2me-opts-worldgen-vanilla: Concurrent Chunk Management Engine (Optimizations/Vanilla WorldGen) 0.2.0+alpha.11.100+1.21 c2me-rewrites-chunk-serializer: Concurrent Chunk Management Engine (Rewrites/Chunk Serializer) 0.2.0+alpha.11.100+1.21 c2me-rewrites-chunkio: Concurrent Chunk Management Engine (Rewrites/Chunk IO) 0.2.0+alpha.11.100+1.21 c2me-server-utils: Concurrent Chunk Management Engine (Server Utils) 0.2.0+alpha.11.100+1.21 c2me-threading-chunkio: Concurrent Chunk Management Engine (Threading/WorldGen) 0.2.0+alpha.11.100+1.21 c2me-threading-lighting: Concurrent Chunk Management Engine (Threading/Lighting) 0.2.0+alpha.11.100+1.21 c2me-threading-worldgen: Concurrent Chunk Management Engine (Threading/WorldGen) 0.2.0+alpha.11.100+1.21 com_electronwill_night-config_core: core 3.6.5 com_electronwill_night-config_toml: toml 3.6.5 com_ibm_async_asyncutil: asyncutil 0.1.0 net_objecthunter_exp4j: exp4j 0.4.8 org_threadly_threadly: threadly 7.0 collisionfix: CollisionFix 1.0.1 continuity: Continuity 3.0.0-beta.5+1.21 detailab: Detail Armor Bar 2.6.3+1.21-fabric dynamic_fps: Dynamic FPS 3.4.3 dynamiccrosshair: Dynamic Crosshair 8.0.1+1.21 dynamiccrosshair-api: DynamicCrosshair API ${api_version} libbamboo: libbamboo 1.21.0 entity_model_features: Entity Model Features 2.1 entity_texture_features: Entity Texture Features 6.1.1 org_apache_httpcomponents_httpmime: httpmime 4.5.10 entityculling: EntityCulling 1.6.6 explosiveenhancement: Explosive Enhancement 1.2.3-1.21.0 fabric-api: Fabric API 0.100.1+1.21 fabric-api-base: Fabric API Base 0.4.42+6573ed8c90 fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.65+b559734490 fabric-biome-api-v1: Fabric Biome API (v1) 13.0.28+6fc22b9990 fabric-block-api-v1: Fabric Block API (v1) 1.0.22+0af3f5a790 fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.10+6573ed8c90 fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.52+0af3f5a790 fabric-client-tags-api-v1: Fabric Client Tags 1.1.15+6573ed8c90 fabric-command-api-v1: Fabric Command API (v1) 1.2.48+f71b366f90 fabric-command-api-v2: Fabric Command API (v2) 2.2.27+6a6dfa1990 fabric-commands-v0: Fabric Commands (v0) 0.2.65+df3654b390 fabric-content-registries-v0: Fabric Content Registries (v0) 8.0.11+b559734490 fabric-convention-tags-v1: Fabric Convention Tags 2.0.12+7f945d5b90 fabric-convention-tags-v2: Fabric Convention Tags (v2) 2.2.1+d153f34490 fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.29+0af3f5a790 fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.1.22+6a6dfa1990 fabric-data-generation-api-v1: Fabric Data Generation API (v1) 20.2.6+16c4ae2590 fabric-dimensions-v1: Fabric Dimensions API (v1) 4.0.0+6fc22b9990 fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.12+6fc22b9990 fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.7.10+e633f88390 fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.52+6573ed8c90 fabric-item-api-v1: Fabric Item API (v1) 11.0.0+afdfc92190 fabric-item-group-api-v1: Fabric Item Group API (v1) 4.1.0+00ab0a6390 fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.47+0af3f5a790 fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.45+df3654b390 fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.3.9+98a7dbbb90 fabric-loot-api-v2: Fabric Loot API (v2) 3.0.9+6573ed8c90 fabric-message-api-v1: Fabric Message API (v1) 6.0.13+6573ed8c90 fabric-model-loading-api-v1: Fabric Model Loading API (v1) 2.0.0+fe474d6b90 fabric-networking-api-v1: Fabric Networking API (v1) 4.1.0+686dcdce90 fabric-object-builder-api-v1: Fabric Object Builder API (v1) 15.1.10+d132107690 fabric-particles-v1: Fabric Particles (v1) 4.0.2+6573ed8c90 fabric-recipe-api-v1: Fabric Recipe API (v1) 5.0.8+6573ed8c90 fabric-registry-sync-v0: Fabric Registry Sync (v0) 5.0.21+b9828ba390 fabric-renderer-api-v1: Fabric Renderer API (v1) 3.2.16+fe474d6b90 fabric-renderer-indigo: Fabric Renderer - Indigo 1.6.3+cc9f121a90 fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.66+df3654b390 fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.48+73761d2e90 fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.1.6+b559734490 fabric-rendering-v0: Fabric Rendering (v0) 1.1.69+df3654b390 fabric-rendering-v1: Fabric Rendering (v1) 5.0.3+d132107690 fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 4.2.1+d153f34490 fabric-resource-loader-v0: Fabric Resource Loader (v0) 1.1.3+b559734490 fabric-screen-api-v1: Fabric Screen API (v1) 2.0.24+b559734490 fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.78+b559734490 fabric-sound-api-v1: Fabric Sound API (v1) 1.0.23+6573ed8c90 fabric-transfer-api-v1: Fabric Transfer API (v1) 5.1.12+b559734490 fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 6.0.12+6573ed8c90 fabricloader: Fabric Loader 0.15.11 mixinextras: MixinExtras 0.3.5 fabricskyboxes: FabricSkyBoxes 0.7.4+mc1.21 ferritecore: FerriteCore 7.0.0 immediatelyfast: ImmediatelyFast 1.2.18+1.21 net_lenni0451_reflect: Reflect 1.3.4 indium: Indium 1.0.33+mc1.21 iris: Iris 1.7.1+mc1.21 io_github_douira_glsl-transformer: glsl-transformer 2.0.1 org_anarres_jcpp: jcpp 1.4.14 org_antlr_antlr4-runtime: antlr4-runtime 4.13.1 java: Java HotSpot(TM) 64-Bit Server VM 22 lithium: Lithium 0.12.5 minecraft: Minecraft 1.21 modernfix: ModernFix 5.18.2+mc1.21 modmenu: Mod Menu 11.0.0-rc.2 placeholder-api: Placeholder API 2.4.0-pre.2+1.21 notenoughanimations: NotEnoughAnimations 1.7.4 packetfixer: Packet Fixer 1.4.1 presencefootsteps: Presence Footsteps 1.10.0+1.21 kirin: Kirin UI 1.19.0+1.21 reeses-sodium-options: Reese's Sodium Options 1.7.2+mc1.21 sodium: Sodium 0.5.9+mc1.21 sodium-extra: Sodium Extra 0.5.7+mc1.21 caffeineconfig: CaffeineConfig 1.3.0+1.17 sound_physics_remastered: Sound Physics Remastered 1.21-1.4.3 Loaded Shaderpack: photon_v1.0a.zip Profile: Custom (+44 options changed by user)

(edited to include logs in a dropdown as well as raw file)

Superkat32 commented 4 months ago

I'm guessing this is because I use the velocity parameters to determine the size of the explosion particles because I didn't know any better way at the time. I do know of a proper way to add custom parameters to the particles now, and I'm guessing that might fix this. However, it'll have to wait until at least next week.

Is this an urgent issue for you and your map? I plan on changing a lot on the back end of this mod soon-ish but I can try to look into this before that if it is important for you and your map.

Rowantale commented 4 months ago

It's not urgent no, I'm in 1.21 and I kinda forgot they added wind charges which are exactly what I'm using it for haha

Daniel99j2 commented 1 month ago

Would like to up this issue, as this is commonly used by server side mods, eg polyfactory, and personal ones, to accelerate the player, but keep movement control

Daniel99j2 commented 1 month ago

At https://github.com/Superkat32/Explosive-Enhancement/blob/c70b767157273857eb794ac01bb37bd425c5da57/src/main/java/net/superkat/explosiveenhancement/mixin/ExplosionMixin.java#L35 you should be able to do && power >= 0 (Maybe > 0)

Superkat32 commented 1 month ago

Would like to up this issue, as this is commonly used by server side mods, eg polyfactory, and personal ones, to accelerate the player, but keep movement control

I will keep this in mind and try to move it higher on my todo list, but it'll still take me time as I want to finish another mod first, then I'll see if I can get to this. I want to merge this bug fix with a few other major changes, which will take time.