Superkat32
commented
2 months ago Oh my goodness me! This will take me some time to get merged and actually upload the update(I'm working really hard on finishing another mod before updating the rest of my mods to 1.21, then coming back to this one), but I really appreciate it!
I've never heard of NPATH complexity before until now, but I appreciate you telling me about it and showing me how to reduce it!
I've left some notes on things I feel are important in case you are curious(I think I accidentally made it a review, don't worry about that, that was my mistake).
Xylonity
The concept of having multiple methods for each explosion is cool, but that increases duplication since they essentially contain the same logic (the two functional ones so far). I haven't modified anything of that anyways tho.
I refactored some of the code into separate methods to reduce the number of processing cycles and thus lower the NPATH complexity. I haven't modified any original comments; I only added volatile constants as arguments in some LOGGER instances to prevent errors when writing data to the dedicated log file. And I also added logs in the configuration generator because it's better to avoid throwing empty exceptions.