search

Superkat32 / Explosive-Enhancement

Enhancing the explosion animation since 2023
https://modrinth.com/mod/explosive-enhancement
MIT License
12 stars 5 forks source link

Feature Request: Under-water Explosions #3

Closed BLUEChester closed 1 year ago

BLUEChester commented 1 year ago

If the explosion is under water it will cause a different 'under-water' animation.

Thanks so much for making this mod, i've been looking for something like this for ages, its such a beautifully made animation! Keep up the great work

Superkat32 commented 1 year ago

I'm not sure if I could make it much brighter. Minecraft already has a slight amount of a darkness effect while underwater. I could make it dimmer, but it would take a little while to do that because of how I have the color fading out setup.

I'm really happy we've been able to make this look really good. 100% a team effort right here.

BLUEChester commented 1 year ago

Wowww!! Wow! Wow wow 👏 bravoo. It looks reallyy cool, if you think its done I would personally be very happy with that as it looks perfect, but if you still want more feedback to perfect it to the max i'll give you some now.

The white in the middle of the animation could possibly have some transparency? Like you can see through it, if that isn't possible then I think just keep it how it is as its very very good. The animation itself is perfect and soo smooth

The bubbles have come a very long way but I would still love to see some additional particles addeed to add just that tiny bit more detail to the effect, such as 'lines', or you could possibly even use the 'water dust' ambient particles that are visible whenever you go in water. I think the bubbles themself should spread out even more, matching the radius of how far the horizontal shockwave goes out. And I love how the bubbles pop now thats super cool, ik you did that ages ago but it just looks so good.

But to be completely honest these 3 things are extremely nitpicky and not needed whatsoever if you reckon its ready for release, you have done an excellent job. Very great work, thanks so much for putting so much of your time into this and keeping us updated with your friendly posts.

Superkat32 commented 1 year ago

Bubbles can spread out even more, and I'll play around with the small bubbles idea.

I don't know if I could change the ambient particles, but I do plan on adding the white lines thing from Minecraft Legends anyways, just haven't gotten to it yet.

Superkat32 commented 1 year ago

Alright guys, we're getting super super close to done with this. I'm pretty sure, unless there are some tweaks that still need to be made or something new suggested that is really cool, the underwater explosions are pretty much done!

New bubbles movement. They move around even more. The amount they move is somewhat random.

https://github.com/Superkat32/Explosive-Enhancement/assets/89557012/d2688793-2d27-4132-8faa-e747fb36b7f0

Quick showcase of the new movement with 500 bubbles.

https://github.com/Superkat32/Explosive-Enhancement/assets/89557012/a2ac8fd2-54d9-4155-b7bf-21cc4f60fc03

I decided for the time being, I am going to push the small bubbles idea to the side. If you would still like for me to try it out, though, I can.

BLUEChester commented 1 year ago

If it's an easy thing to change, I'd possibly make the rate at which the bubbles slow down happen over a longer period of time, as they seem to slow down very abruptly. But that's just my personal opinion/nitpick and I have no reason to back it up lol.

Don't worry about the small bubbles I don't think it needs it anymore to be honest. What I do think you should do is just, very slightly reduce the max size of the current bubbles, as some of them look a bit big I reckon.

And just so you know I'm a huge nitpicker and perfectionist, at some point, you will have to ignore me and just release it as I could go on for days about the tiniest little details about these sorts of things lol.

But yeah this update is shaping up to be really awesome now, it looks very ready for release. Adding a random factor to the bubbles certainly shows, it looks way more dynamic now I reckon.

Superkat32 commented 1 year ago

I could try to adjust the movement like that, but it might take some trial and error.

I'm also a perfectionist and it'll probably be the end of me one day xD

BLUEChester commented 1 year ago

Thats so funny, i totally agree im the same

Superkat32 commented 1 year ago

Pretty sure this will be the last update to the bubble's movement. They move roughly the same, but will slow down a little bit slower over time, so as to make the slow down less sudden. Some bubbles will also move upwards a little bit more often upon the initial explosion, because it felt like too many bubbles were in the same y-level(if that makes any sense). Just like last time, there is still a big factor of randomness for each bubble's movement.

The game's brightness has been turned up for this video because I remembered that there was a setting for that.

https://github.com/Superkat32/Explosive-Enhancement/assets/89557012/8a153677-331d-4c69-a0b3-4b067b365b1d

IceBlossom commented 1 year ago

Looks good to me! How's the progress on the 1.19.4 port? I wanted to ask earlier, but I didn't want to make you feel like you had to hurry up.

Superkat32 commented 1 year ago

It is pretty close to done. I can give you an early build if you'd like. The last thing I have to do really is test it thoroughly, so having an extra person or two test it would actually be nice. Really, the last thing I have to do for all the versions is test it all well.

BLUEChester commented 1 year ago

Awesome, im super uper happy with how it looks now. The bubbles look perfect, I have nothing more to nitpick.

Awesome work 👍

Superkat32 commented 1 year ago

Whoo! 🎉

IceBlossom commented 1 year ago

It is pretty close to done. I can give you an early build if you'd like. The last thing I have to do really is test it thoroughly, so having an extra person or two test it would actually be nice. Really, the last thing I have to do for all the versions is test it all well.

Saddest part is that MCC Island is closed right now to have maintenance so it can launch to Open Beta, so testing it with Hole in the Wall is out of the question for a week or two. But once it comes out, I'll be sure to get a clip of it. :>

Superkat32 commented 1 year ago

So I was trying to get the update out today. I started doing the final testing and found a bug. I fixed the bug in 1.19.4 instead of 1.19.2(where I meant to), so I tried to apply the changes to the older versions (1.19.2 & 1.19.3) using Git instead of manually copy-pasting stuff. However, I ended up breaking.. a lot of things... twice. I believe I have fixed the versions, but it took almost an hour and a half. I think I lost some commit history(doesn't affect final product), which in the end doesn't mean anything, but it is something to note I guess.

Will probably continue working on this tomorrow. Should be able to get it out by then, assuming nothing else decides to break.

Superkat32 commented 1 year ago

It is finally here!!!!

https://modrinth.com/mod/explosive-enhancement/changelog

Thank you guys so much for all of the feedback and patience! It has been really fun working with y'all getting this effect looking really nice! It 100% would NOT have made it this far without you guys.

IceBlossom commented 1 year ago

Let's go! I just tested it, and here's how it looked like with my set-up underwater! I will test Hole in the Wall once it comes out, trust me :D https://medal.tv/games/minecraft/clips/1armIcUURWMhAs/d1337ArxdlTM?invite=cr-MSx6TmcsMjI0MDQ5Niw

BLUEChester commented 1 year ago

Let's go! I just tested it, and here's how it looked like with my set-up underwater! I will test Hole in the Wall once it comes out, trust me :D https://medal.tv/games/minecraft/clips/1armIcUURWMhAs/d1337ArxdlTM?invite=cr-MSx6TmcsMjI0MDQ5Niw

Wowowowowowwowow2ow! It looks soo awesome, definitely using this once I get a chance. Sooo hyped about this, the sparks look so good too

BLUEChester commented 1 year ago

Also thank you @Superkat32 for supporting older 1.19 versions like 1.19.2, thats so clutch, much appreciated 🙏

Superkat32 commented 1 year ago

Let's go! I just tested it, and here's how it looked like with my set-up underwater! I will test Hole in the Wall once it comes out, trust me :D https://medal.tv/games/minecraft/clips/1armIcUURWMhAs/d1337ArxdlTM?invite=cr-MSx6TmcsMjI0MDQ5Niw

OH MY GOODNESS IT LOOKS SO GOOD WITH SHADERS WOW

Also thank you @Superkat32 for supporting older 1.19 versions like 1.19.2, thats so clutch, much appreciated 🙏

Supporting multiple versions, as I found out, is very time consuming. However, I think it is well worth it knowing that at least one person can get some good mileage out of it. :D

BLUEChester commented 1 year ago

Also, if you're ever seeking any feedback for anything you're making just let me know im more then happy to help out if you need it. My discord is Chester#7783