Superkat32 / PostmortalParticles

Overhauls the totem of undying particle effect.
https://modrinth.com/mod/postmortal-particles
MIT License
2 stars 0 forks source link

[Feature Request] Compat with Extraordinary Extra Totems & AdditionZ #5

Open xR4YM0ND opened 11 months ago

xR4YM0ND commented 11 months ago

would be neat to see a compat for modded totems as well

would love to see different colors that match & maybe other shapes / styles for different totems

Would love to add this mod / datapack to our modpack Aged ~ hosted on Modrinth

Superkat32 commented 11 months ago

Ooh, that would go well with #2 and #4 . I'll look into it, but based on how my schedule has been turning out for me recently, I doubt it'll be anytime soon. Thanks for the suggestion!

Superkat32 commented 11 months ago

Progress hasn't started, but a plan has been made and I'd like to hear your thoughts on how I'm hopefully going to be implementing some stuff.

Firstly, I'm going to be adding at the very least #2 (maybe #3 as well?). Then, I'm going to make an API which would allow for other mods to add their own set of options for this mod. The idea is that a developer would have full control over the initial color of the particles dedicated to their mod's custom totem. Then, anybody(like a modpack developer or user) could come in and change the colors to their liking, while still keeping the special colors of other totems added by both Postmortal Particles and other mods using the API unchanged. Once the API is operational and released, I'm going to try and PR compatibility to Extraordinary Extra Totems, AdditionZ, and Charm of Undying(solving both this and #4 ).

What I'd like feedback on is the amount of control you have over the options as a modpack developer. Should things go well, a user/modpack dev would have control over the visibility of individual particles and color for a set of particles from each usage of the API(including the default totem particles). For example, the default totem would have light green particles and a few particles disabled, but the particles from AdditionZ could be dark blue to match its texture and have all particles enabled. Hopefully everything would be configured similarly to how it is right now(you go ingame, you change settings, it saves to a json file).

I'd also like to have things set up in a way where mods using the API can be removed and readded without consequence(maybe except a partial config reset for the mod using the API). I have no idea how on earth I'm going to do the API, but I'm sure it is possible.

(There is also no guarantee that my PRs get merged into the other mods, but hopefully I'll have made things clean enough to get merged. I would say don't create issues on their respective repos as I have no idea when I'll be able to finish this. My hope is to finish up a PR for something else, continue and finish another mod of mine, then either update You Were Slain or this mod, depends how I feel lol)

Hopefully I explained everything well, if you need clarification then let me know 👍

xR4YM0ND commented 10 months ago

Sry for my late reply.

Me personal , i like when things are as open as they could be (open source , data driven (asset driven)

So that i as a modpack dev have as much control as possible.

But i also appreciate a good compat / config options / partly data driven