Superkikim / mh-maxsmart-hass

Power Strip and Smart Plug home assistant custom component for Revogi based devices
2 stars 1 forks source link

Minor: Logos missing #5

Open lmaertin opened 1 year ago

lmaertin commented 1 year ago

Despite the fact the addon provides logo.jpg and icon.jpg, those assets are not used by HA. HA refers to the central brand database instead, e.g., for the dark theme:

https://brands.home-assistant.io/maxsmart/dark_icon.png

May add your logos here: https://developers.home-assistant.io/blog/2020/05/08/logos-custom-integrations/

May I'm creating a fork for the revogi strip to fix other issues and add the revogi logo here as well.

Superkikim commented 1 year ago

Hi. Bear with me some more hours. I've been wasting time trying to be perfect and it's a mistake :) I've been struggling trying to show a form the user to set device name and port names at setup. But I cannot have this work properly.

However,, I will publish within the next hours a new release which will publish local names for FW 1.XX, and just generic names (Port 1 - Port 6) for FW 2.xx and FW 3.XX.

As per the logos, I tried to publish them but they been rejected for stupid reasons ! I gave up.

If you want to try, be my guest :) I think the logos I have prepared are absolutely perfect for the purpose of this. I just published on the master branch the logos I tried to publish to the brand repo. I also fixed the version number which was breaking the component.