search

Supersonido / rebar_mix

rebar3 plugin for building Elixir dependencies with mix
Apache License 2.0
53 stars 20 forks source link

Let elixir handle protocol consolidation #17

Closed starbelly closed 4 years ago

starbelly commented 4 years ago

It seems as though we can simply let elixir and friends handle protocol consolidation which resolves issue(s) in pulling in deps such as Jason, Decimal, etc. 

1> 'Elixir.Jason':encode('Elixir.Decimal':new(<<"1.0">>)).
{ok,<<"\"1.0\"">>}
2>

It may be there is a piece to the puzzle here I'm not understanding about protocols and releases and why it needs to be handled the way it is. If this is not the case, I'll happily add a test case to go along with this change.

tsloughter commented 4 years ago

@starbelly as far as I know this is not consolidating the protocols so is not what anyone would want to use in production. It technically works, but is slow.

starbelly commented 4 years ago

Closing this per misunderstanding of protocol consolidation on my end.