Closed suhasasumukh closed 9 months ago
Hm doesn't seem anything worthy of changing here. Its removing typehinting from a lot of places which makes the code worse and the main thing, which it introduced, that is splitting a single function into multiple is not ideal for an SDK either. Since typehinting would show them as seperate class methods that a user would never end up using since its a part of one function only. Also introduces confusion for user as to why these seperate function exists. Closing the PR. You can have a look into open issues, those things would be 100% merged if fixed
compile_transaction
method into smaller, more focused methods to improve maintainabilityKeypair