search

Suppenhuhn79 / sbhowc

A warband calculator for the "Song of Blades and Heroes" fantasy tabletop skirmish rules.
https://suppenhuhn79.github.io/sbhowc/
GNU Affero General Public License v3.0
0 stars 0 forks source link

personality points check is too strict #24

Closed Suppenhuhn79 closed 3 years ago

Suppenhuhn79 commented 3 years ago

Having personality points of 33,x% throws a rule violation message.

e.g. having a warband of 296 points in total and 100 points in personalities (33,784%) will trigger the check with misleading text:

Total: 6 figures with 296 points (33% personalities) Rule violation:

  • At most 98 points in personalities allowed.

Example warband: v1Amazons@GHeroine+of+the+amazons*hrs2@GAmazon+bow+master*s3go@BYoung+amazon*ac@1Amazon+shaman*mu@bLLioness*ansvm3@

Check should not be "!(x > 33%)" but "x < 34%"

Suppenhuhn79 commented 3 years ago

Condition stays same. Key is, it's not personalityPointsAllowed = Number(Math.floor(warbandPoints / 3)); but personalityPointsAllowed = Number(Math.floor(warbandPoints * 0.34));

Suppenhuhn79 commented 3 years ago

Rule check does not trigger for warbands having 102 personality points in 300 points total. v11/3+personalities+check+test@RPers#*hrbean@0Pers#2*cc@eGNon-Pers+fillers@QRemaining+points+filler*angb@

Suppenhuhn79 commented 3 years ago

Solution: Check if personality points > 33% (insetad of total points).