search

SupposeNot / RAMP

Research Assistant for Maps and Polytopes
4 stars 0 forks source link

IsSggi technical change #112

Closed CunningGabe closed 2 years ago

CunningGabe commented 2 years ago

Anything that has an argument of type IsSggi should be changed to IsGroup and then check IsSggi.

CunningGabe commented 2 years ago

It turns out that the only place IsSggi is used as an argument type is in IsQuotient. This tests whether one Sggi is a quotient of the other in the usual way; i.e. sending generators to generators. I think we probably want to keep this function as it is. So we can either:

  1. Leave init.g alone, with sggi.gd up at the top with types.gd, or
  2. Move some stuff out of sggi.gd into types.gd Preferences?
SupposeNot commented 2 years ago

I think I'd move the type portion of sggi.gd into types.gd.

CunningGabe commented 2 years ago

I can't figure out how to do this gracefully without messing up the documentation. I'm going to close this as "not a big deal".