search

SupposeNot / RAMP

Research Assistant for Maps and Polytopes
4 stars 0 forks source link

Error in generating small toroidal maps #139

Closed CunningGabe closed 2 years ago

CunningGabe commented 2 years ago

gap> M := ToroidalMap44([1,1],[0,4]); Error, Couldn't get a point in the fundamental region! at /proc/cygdrive/C/gap/pkg/RAMP/lib/toroids.gi:137 called from TranslateRight( i ) at /proc/cygdrive/C/gap/pkg/RAMP/lib/toroids.gi:175 called from <function "ToroidalMap44">( <arguments> )

But note that it's possible to generate this in another way:

gap> M := CubicTiling(2) / "h2 r1 h2 r1, r1 h2^4 r1"; 3-maniplex gap> Size(M); 32

Make sure that ToroidalMap44 works even in small edge-cases.

CunningGabe commented 2 years ago

Fixed in 5b86b30e11373ed2e54d29c158aea2d7288bd70a.

CunningGabe commented 2 years ago

Oops, still not completely solved. For example, ToroidalMap44([0,1],[2,3]) doesn't work.

CunningGabe commented 2 years ago

Fixed using a much cleaner approach to finding a point inside the fundamental region that is equivalent to one outside the fundamental region, in 86811bbee5adf1ada42eead2753b7df8243dd14c.