Closed CAPiedade closed 9 months ago
That's ... weird. Poking at it.
Ok, I think I've figured out what the issue is. The existing code assumes you aren't using repeated elements as generators. I'll work on a fix and get that posted shortly.
Fixed in 4fe8236.
Yeah, I see that one of our base cases is that if there are 2 generators, then it tries to check whether the group is dihedral, which it does by checking that the order of the group is 2 times the order of g.1*g.2. But if g.1 = g.2, then this calculation returns true even though we don't want it too. Oops!
I was using the IsStringC function with this set of generators:
But k[2] = k[3], not being an independent set of generators.
In a personal code that was giving the same error I found out that I was intersecting the set of generators of each subgroup where I should be intersecting the set of indexes of the generators of each subgroup.