search

SupraSummus / ipfs-api-mount

Mount IPFS directory as local FS.
MIT License
27 stars 5 forks source link

add options to mount read-only and set the fuse-mount-option allow_other #16

Closed RubenKelevra closed 4 years ago

RubenKelevra commented 4 years ago

fixes #13

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files           2        2           
  Lines         221      221           
=======================================
  Hits          174      174           
  Misses         47       47
Impacted Files Coverage Δ
ipfs_api_mount/ipfs_mounted.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1c4389...3c91c91. Read the comment docs.

SupraSummus commented 4 years ago

Thanks for contribution.

I've rebased and merged it locally. Also, I've removed the read-only parameter. Now the mount is always read-only.

RubenKelevra commented 4 years ago

Thanks for contribution.

I've rebased and merged it locally. Also, I've removed the read-only parameter. Now the mount is always read-only.

I wasn't sure about any plans to do write requests in the future, that's the reason for exposing it. :)

SupraSummus commented 4 years ago

I thought of implementing write-enabled mount point, indeed. But I'm not going to write this any time soon. PR's are welcome ;D