search

Suprcode / Crystal

Legend of Mir 2 - Official Public Crystal Source
1.12k stars 682 forks source link

Gold only gameshop #731

Open JevLOMCN opened 1 year ago

JevLOMCN commented 1 year ago

Currently only selecting Gold as the only usable currency doesn't work. If gold only is set, it will reset to Credit only. If both gold and credit are set, it will allow both. (Works fine) If credit only is set, it will allow credits only. (Works fine)

image

Suprcode commented 1 year ago

its a gameshop - credits are required. if you want to buy items with gold just put them in a regular NPC

JevLOMCN commented 1 year ago

So this is intentional? Don't see why it can't work with either currency.

Suprcode commented 1 year ago

It was originally always intentional for the gameshop to require both gamegold and gold as currency.

However it was recently changed to allow gold to be turned off.

You could change it to allow just gold, I just don't see why you'd have an item for sale in the gameshop with just gold. At this point just switch off the gameshop and use regular npcs lol.

Leave the issue open to allow this change if you want.

JevLOMCN commented 1 year ago

I just feel it's better to give the server owner the ability to have either. I understand your reasonings but gameshop could be just for new featured items.

meacher0 commented 3 months ago

I think the confusing part is client side, there's only tick boxes for buy with Gold OR Credits. Oddly, the Client already tries to pass PaymentType(PType) to the server but the server doesn't read it...