Suprcode / Zircon

Legend of Mir 3 - Official Public Zircon Source
337 stars 256 forks source link

DXItemCell in-front of BeltDialog #155

Open josh-74 opened 1 month ago

josh-74 commented 1 month ago

//

josh-74 commented 1 month ago

Closed

Suprcode commented 1 month ago

I assume this is still an issue which needs fixing? If not please specify the reason for closing it

phoenixvdp commented 1 month ago

To reproduce the issue, (atleast for me), Create 10 healthpotions, and assign them to slots 1-4 on your belt, log out and back in.

wait about 5-10 seconds, the slot 1 image seems to fade out (like the fade system text).

https://github.com/user-attachments/assets/39e636db-7a3e-4685-84ee-13282927ba9e

josh-74 commented 1 month ago

I assume this is still an issue which needs fixing? If not please specify the reason for closing it

Issue's fixed within the provided notepad apologies for closing it

To reproduce the issue, (atleast for me), Create 10 healthpotions, and assign them to slots 1-4 on your belt, log out and back in.

wait about 5-10 seconds, the slot 1 image seems to fade out (like the fade system text).

belt_icon.mp4

You'll need to download the latest files in-order to get the past the error that you're seeing.

phoenixvdp commented 1 month ago

I still had an issue with the beltdialog after trying the above changes, but it was specific to when I had 1 slot showing on the beltdialog and only on the initial load of the UI, it self-corrected on resize. I have since fixed this on my code and have left the code here incase it's helpful for fixing the issue in the base source.

BeltDialog.cs.txt

Suprcode commented 1 month ago

I've added in the above changes, and it does indeed bring back the slot 1 transparent issue. I think the previous change just coincidentally fixed it in certain scenarios. Still not sure what's causing that, but will leave this ticket open until its resolved again.

Suprcode commented 1 month ago

Seems to be fixed now with the addition of @phoenixvdp changes. The invisibility and 1 slot position both seem to be working correctly now.

Suprcode commented 3 weeks ago

Reopening as issue has appeared again