Supreeeme / xwayland-satellite

Xwayland outside your Wayland
Mozilla Public License 2.0
94 stars 4 forks source link

Steam big picture mode doesn't work #18

Closed FreeFull closed 1 month ago

FreeFull commented 1 month ago

When clicking the big picture button, the Steam window fails to go fullscreen, and also turns completely transparent (with only the border remaining). The only way to restore it to normal seems to be restarting Steam.

Supreeeme commented 1 month ago

Do you see this consistently? I only see big picture occassionally fail to open (fixed with a restart of steam), and I don't see the transparent window.

FreeFull commented 1 month ago

The behaviour does seem to be a bit different now: Big Picture will open up fullscreen, but with a black screen, but will eventually work after trying a few times. When exiting, the Steam window seems to end up fully black sometimes, but fullscreening it and then unfullscreening fixes it.

Supreeeme commented 1 month ago

Ah yeah, this is more inline with what I'm seeing. I think this might be related to Xwayland 24.1, I don't have the black screen issues on 23...

Minion3665 commented 1 month ago

I'm reproducing this with NixOS+niri+xwayland 24, pinning xwayland to 23 solves the issue for me

jonseppanen commented 1 month ago

Do you have a flake for your xwayland-satellite and pinned xwayland? Im having trouble getting this all to work with Niri myself...

Minion3665 commented 1 month ago

@jonseppanen

Do you have a flake for your xwayland-satellite and pinned xwayland? Im having trouble getting this all to work with Niri myself...

yes, although I have seen issues with some of my games failing to launch when using pinned xwayland.

Regardless, here's my patch: https://git.clicks.codes/plugins/gitiles/Chimera/NixFiles/+/889835e018f7ad62cbd8e28854d5116085cb521d%5E%21/

You can't directly use the package from my flake, since as I haven't yet merged it. Probably I won't merge the xwayland 23 version anyway because of the game launch issues... Hopefully you'll find the package useful anyway. I'd particularly look at packages/xwayland-satellite/default.nix which is at the bottom of that diff.

If you'd like to ask any other questions about my package/that flake I imagine they'd be off-topic for the issue, please feel free to send me an email instead - minion@clicks.codes

Supreeeme commented 1 month ago

Opened an issue for the black screen upstream: https://gitlab.freedesktop.org/xorg/xserver/-/issues/1679

Supreeeme commented 1 month ago

There was an (Xwayland) patch posted in the upstream issue that fixed the black screen issue for me. As this is an upstream issue with a fix on the way, I'm gonna close this.