search

Suprnovae / abc-totaal-notitieblok

1 stars 0 forks source link

Setup Camera extension #2

Closed vidbina closed 8 years ago

vidbina commented 8 years ago

We need to have https://github.com/lwansbrough/react-native-camera set up for iOS and Android

vidbina commented 8 years ago

Just add a simple button in the iOS and Android UI's to trigger the camera. We'll move it to it's intended place later. We just need it to work now :wink:

zirconias commented 8 years ago

cool,
what about branching, features and bug fixes ? a simple commit ?

vidbina commented 8 years ago

Oh yeah. Forgot to mention that. Just start a setup/camera branch. You could implement it for iOS and Android in separate commits 😉

I merged the latest changes to master so just start your branch from there.

zirconias commented 8 years ago

sounds great, (y)

zirconias commented 8 years ago

we can close the issue now ?

vidbina commented 8 years ago

I have to review it first. Only closes when merged to master.

vidbina commented 8 years ago

There seems to be an issue with renderHome(). I've just ignored it and tried returning the component JSX within the switch-case (instead of the renderHome() func) to test how it functions. Discovered that the navigation pushes the Camera views into place, but there seems to be no interface to engage the camera. Furthermore, the Android back button does not pop items from the navigator stack. So I got a few extra items for you to work on, but as far as setting up the extention goes... you've done the job.

zirconias commented 8 years ago

my fault, i commited without testing the renderhome, i just refactored code and commited i was on my way to home. like you did i first used return(component ) directly on the switch case, i'll review it again