SurLaTable / slt-ui

:books: An end to end solution for bringing React components to your legacy system.
https://surlatable.github.io/slt-ui/
GNU General Public License v2.0
9 stars 1 forks source link

Feature/combine cdp components #66

Closed LeonardMeagher2 closed 6 years ago

ryanpcmcquen commented 6 years ago

@LeonardMeagher2, should we bump the version as well? 1.4.0?

ryanpcmcquen commented 6 years ago

Sorry, I thought we were already at 1.3.0, ignore my last comment.

ryanpcmcquen commented 6 years ago

@LeonardMeagher2, looks like the build is failing because of a capitalization issue:

material-ui/icons/close

Should be:

material-ui/icons/Close
codecov[bot] commented 6 years ago

Codecov Report

Merging #66 into develop will increase coverage by 0.16%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #66      +/-   ##
========================================
+ Coverage    25.83%   26%   +0.16%     
========================================
  Files           23    25       +2     
  Lines          387   573     +186     
  Branches        72   108      +36     
========================================
+ Hits           100   149      +49     
- Misses         231   344     +113     
- Partials        56    80      +24
Impacted Files Coverage Δ
src/ClassDateTimePicker/ClassDateTimePicker.js 12.16% <0%> (-21.18%) :arrow_down:
src/services/slt-class-times/actions.js 9.67% <0%> (-20.33%) :arrow_down:
src/services/google-maps/actions.js 11.11% <0%> (-13.89%) :arrow_down:
src/StoreList/StoreList.js 10.52% <0%> (-8.53%) :arrow_down:
src/services/slt-stores/selectors.js 75% <0%> (-8.34%) :arrow_down:
src/ComparisonChart/ComparisonBar/ComparisonBar.js 14.28% <0%> (-5.72%) :arrow_down:
...isonChart/ComparisonCheckbox/ComparisonCheckbox.js 14.28% <0%> (-5.72%) :arrow_down:
src/StoreSelector/StoreSelector.js 7.69% <0%> (-4.08%) :arrow_down:
src/services/slt-stores/actions.js 28% <0%> (-2.77%) :arrow_down:
src/LocationButton/LocationButton.js 13.04% <0%> (-1.96%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7369b24...1631cec. Read the comment docs.