SurLaTable / slt-ui

:books: An end to end solution for bringing React components to your legacy system.
https://surlatable.github.io/slt-ui/
GNU General Public License v2.0
9 stars 1 forks source link

Change eslint rules to allow Prettier to do its thing. #70

Closed ryanpcmcquen closed 5 years ago

ryanpcmcquen commented 5 years ago

Relates to: https://github.com/prettier/prettier/issues/4199

Prettier likes to mix spaces and tabs in some scenarios, this keeps eslint from thinking this is an error, by adding the rule:

"no-mixed-spaces-and-tabs": ["warn", "smart-tabs"],

Signed-off-by: Ryan P. C. McQuen ryanpcmcquen@member.fsf.org

LeonardMeagher2 commented 5 years ago

I usually see the mixed spaces and tabs after pasting something in, and usually just doing ctrl +alt + f (in atom) fixes it.

codecov[bot] commented 5 years ago

Codecov Report

Merging #70 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #70   +/-   ##
=====================================
  Coverage       26%   26%           
=====================================
  Files           25    25           
  Lines          573   573           
  Branches       108   108           
=====================================
  Hits           149   149           
  Misses         344   344           
  Partials        80    80

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad2512f...273f151. Read the comment docs.

ryanpcmcquen commented 5 years ago

@LeonardMeagher2, try the snippet here: https://github.com/prettier/prettier-eslint/issues/188

const configureStore = (initialState, initialReducers) => {
    const store = createStore(
        initialReducers
            ? combineReducers({
                    ...initialReducers
              })
            : (state) => state,
        initialState,
        middlware
    );
    store.asyncReducers = initialReducers ? { ...initialReducers } : {};
    return store;
};