search

Surekha-Scintillations / slack-project

Slack Project
0 stars 0 forks source link

Review Comments #1

Open Surekha-Scintillations opened 6 years ago

Surekha-Scintillations commented 6 years ago

-From Neelanjan

  1. Please implement Redux for state management and write unit test cases for your reducers.
  2. Identify all async operations and write Sagas for them.
  3. Write unit test cases for your React components using Enzyme.
  4. Unable to create/join public/private rooms.
  5. Material - UI not used.
  6. CI/CD missing.
Surekha-Scintillations commented 6 years ago

All the above points are done. Please verify

Fawke commented 6 years ago

After second review, Sometimes, the messages are appearing twice when a user types a message on any channel.

Rest, all the test cases are passing and funtionality is working.