search

Surge-ee / SurgerEE

A collection of simple tags for expressionengine that make template development easier.
Mozilla Public License 2.0
37 stars 8 forks source link

Number Formats #3

Closed nonprofit-tech closed 12 years ago

nonprofit-tech commented 12 years ago

Is it possible to add support for number formats? I'm thinking support for some of the standards like: adding comma for thousands, adding dollar sign for money, rounding decimal spaces to two. I was using 'Number Format' but it's not really being supported under EE2, plus the less plugin the better, and SurgerEE has been great for other common uses.

EpocSquadron commented 12 years ago

This is definitely something that can be added. We'll look into it right away. :)

nonprofit-tech commented 12 years ago

That sounds awesome.

EpocSquadron commented 12 years ago

Mind testing the plugin using the develop branch? No support added for monetary formats yet, as that seems a bit involved . Should be able to invoke like so: 

 {exp:surgeree:format_number number="5654234234.798" precision="8" separator="'" decimal="," groupsize="4"}

All options except number are optional. Defaults to en_US number format.

EpocSquadron commented 12 years ago

In absence of further feedback I'm closing this issue. This functionality will be in the next release.

nonprofit-tech commented 12 years ago

Sorry! Yes I did test. I wanted to play with more, but we launched into beta and I've been squashing bugs for the last week instead. From my notes, it didn't respond properly when using an EE number like: {number}, but I didn't have time to test if that was a number type issue, like if it needed to be an integer vs just number, etc. I believe it did work when I used PHP to insert the number.

The project this was for, won't kick back into gear for another week or so, so I'll have more details then.

EpocSquadron commented 12 years ago

@nonprofit-tech: No worries at all. It's open source, these things happen. Glad to hear you havve feedback though, if I have time I'll investigate that as well, but if you get some specifics please feel free to open another issue.