Surnet / docker-wkhtmltopdf

wkhtmltopdf for multiple base images
https://hub.docker.com/u/surnet/
MIT License
360 stars 65 forks source link

java based images #5

Closed fobbyal closed 5 years ago

fobbyal commented 5 years ago

would you be interested in adding some java based images. i would like to experiment and submit a PR

fobbyal commented 5 years ago

i realized this is unnecessary as i can do the following

FROM surnet/alpine-wkhtmltopdf:3.8-0.12.5-full as builder
FROM openjdk:8-jdk-alpine3.8
# install wkhtmltopdf
RUN apk add --no-cache \
  curl \
  libstdc++ \
  libx11 \
  libxrender \
  libxext \
  libssl1.0 \
  ca-certificates \
  fontconfig \
  freetype \
  ttf-dejavu \
  ttf-droid \
  ttf-freefont \
  ttf-liberation \
  ttf-ubuntu-font-family \
&& apk add --no-cache --virtual .build-deps \
  msttcorefonts-installer \
\
# Install microsoft fonts
&& update-ms-fonts \
&& fc-cache -f \
\
# Clean up when done
&& rm -rf /tmp/* \
&& apk del .build-deps
COPY --from=builder /bin/wkhtmltopdf /bin/wkhtmltopdf
COPY --from=builder /bin/wkhtmltoimage /bin/wkhtmltoimage
COPY --from=builder /bin/libwkhtmltox* /bin/

Thank you for creating this repo :+1:

chdanielmueller commented 5 years ago

Hi @fobbyal,

Thank you for sharing your Dockerfile. I might add this to the README.md as a short explanation in how to use the built wkhtmltopdf in other images. I hope you are fine with this?

Cheers, Daniel

fobbyal commented 5 years ago

of course thanks again for the original build.

On Sun, Apr 28, 2019 at 7:59 AM Daniel Müller notifications@github.com wrote:

Hi @fobbyal https://github.com/fobbyal,

Thank you for sharing your Dockerfile. I might add this to the README.md as a short explanation in how to use the built wkhtmltopdf in other images. I hope you are fine with this?

Cheers, Daniel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Surnet/docker-wkhtmltopdf/issues/5#issuecomment-487372504, or mute the thread https://github.com/notifications/unsubscribe-auth/AB3UY7OEXJ2C4TXWL7YHJB3PSWGTBANCNFSM4HI3N7JA .

-- Alex Liang