search

Surreal-Net / Surreal.Net

Database driver for SurrealDB available for REST and RPC sessions.
Apache License 2.0
57 stars 7 forks source link

Added round trip tests for both RPC and REST Client #16

Closed Du-z closed 2 years ago

Du-z commented 2 years ago

I have commented out all failing code to help with remediation

I have added TryGetObjectCollection<T>(out List<T> document) as a simple shortcut to get the deserialized document. It ended up being far more complicated then required as the _json document can come in two shapes.

Perhaps this can be remove in favor of a ORM Implementation?

ProphetLamb commented 2 years ago

First and foremost thank you for your contribution! I intentionally did not try to implement an ORM because, that would be out of scope for this project, but I realize that noone wants to wait for a "proper" ORM. I have been working on integration into the Dapper micro ORM, but event that will take a few

I'll take a few minutes to review the PR, and probably merge it with an Obsolete warning for the TryGetObjectCollection, so that we know that a revision is required.

Du-z commented 2 years ago

Thanks @ProphetLamb I'll open some issues for the round trip fixes.