Add agent delete functionality

SurveyMonkey / pyteamcity

Use the TeamCity REST API from Python

51 stars 50 forks source link

Add agent delete functionality #81

Closed iluxame closed 7 years ago

iluxame commented 7 years ago

Hi,

I can see that legacy api tests are broken but it seems to be not related to my commit.

aconrad commented 7 years ago

You are right, it's unrelated to your commit. I'll take a look today and figure out what's wrong. I want tests to pass before merging.

coveralls commented 7 years ago

Coverage decreased (-0.008%) to 96.388% when pulling 245e60890c2a0f1d88b7bb8fc53fa216c99b8315 on iluxame:master into a3308f9e4e488daf7862c0c99b78a08dbf7c6e4f on SurveyMonkey:master.

aconrad commented 7 years ago

The couverture-io report says the coverage has worsened. If you click "Details" you can see what's left to be tested, you are missing a use-case.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 96.43% when pulling ac9703f477347618aa398dfa1da57d0c4ab92da7 on iluxame:master into 32795831d3dbd1efb565d596b4f877b841903d82 on SurveyMonkey:master.

iluxame commented 7 years ago

Thanks for your review. I've added the relevant test case and now agent.py coverage is 100% again

aconrad commented 7 years ago

@msabramo mind reviewing this quickly?

aconrad commented 7 years ago

@iluxame can you please update the CHANGES file as well?

coveralls commented 7 years ago

Coverage increased (+0.03%) to 96.43% when pulling d7213a840a4a0272c0085284782f9a96d8127e23 on iluxame:master into 32795831d3dbd1efb565d596b4f877b841903d82 on SurveyMonkey:master.

iluxame commented 7 years ago

@aconrad @msabramo Can you please review my pull request?

aconrad commented 7 years ago

@iluxame thanks for your contribution. I am going to merge this because the code looks good. Although I don't have the authority to make a release, I think only @msabramo has.

msabramo commented 7 years ago

Thanks, @aconrad for reviewing and fixing the build problems!

I'll draft a release...