SurveyMonkey / pyteamcity

Use the TeamCity REST API from Python
51 stars 50 forks source link

Add pyteamcity.future to packages #83

Closed baopham closed 7 years ago

baopham commented 7 years ago

This is so that we can install and use pyteamcity.future using pip:

pip install -e git+https://github.com/SurveyMonkey/pyteamcity#egg=pyteamcity

while waiting for the new API to be officially released (#70)

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 96.43% when pulling 4e2c479308918d1c7df40dc6063747205819bc9f on baopham:master into 434cdd372a7dd692d6ebad78621f0764d445381b on SurveyMonkey:master.

msabramo commented 7 years ago

@aconrad This looks good, but I can't merge it, I think because I removed myself from the SurveyMonkey org. Want to add me back or merge it?

aconrad commented 7 years ago

@msabramo someone removed me from the SurveyMonkey org, but then I became a collaborator which retained my rights and permissions. I just added you as a collaborator, let me know if it works for you.

aconrad commented 7 years ago

Also, do you care about my comment?

msabramo commented 7 years ago

Hmmm, I still don't see a merge button.

Oh did you comment on this? I don't see a comment. Or did you mean that you have an opinion on this that you haven't voiced yet? In either case, I definitely want to hear if you have any opinions!

aconrad commented 7 years ago

I created a review, but I think it was "pending". Never used the "start a review" feature of Github yet.

aconrad commented 7 years ago

I checked, it seems that you need to accept the invite to become a collaborator.

aconrad commented 7 years ago

@msabramo you have to follow this link: https://github.com/SurveyMonkey/pyteamcity/invitations

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 96.43% when pulling f2a4c599bdb46a34399c828a0d412e8e3925bffd on baopham:master into 434cdd372a7dd692d6ebad78621f0764d445381b on SurveyMonkey:master.

msabramo commented 7 years ago

Thanks @aconrad! I now have the ability to merge and I like your comment and I see @baopham already implemented it. Merging...

msabramo commented 7 years ago

Thanks @aconrad and @baopham!