Clean Architecture - Githubissues

Suryansh1720001 / Taaveez

Meet Taaveez, the awesome new app designed specifically for artists and entertainers. It's incredibly user-friendly—just a few taps, and you can jot down your creative ideas and cool stuff. This project highlights a well-executed Android implementation with a modern design, using the latest Android development tools.

https://play.google.com/store/apps/details?id=com.itssuryansh.taaveez

Apache License 2.0

36 stars 49 forks source link

Clean Architecture #79

Closed essy16 closed 10 months ago

essy16 commented 1 year ago

Fixes Issue

Closes #13 Closes #11

Changes proposed

--> I have added dependency Injection to the project -->I have changed the architecture to Clean Architecture with MVVM

Check List (Check all the applicable boxes)

[ x] My code follows the code style of this project.
[ x] All new and existing tests passed.
[ x] This PR does not contain plagiarized content.
[ ]x The title of my pull request is a short description of the requested changes.

Screenshots

Screen Shot 2023-06-13 at 5 17 18 PM

Demo video

Note to reviewers

Suryansh1720001 commented 1 year ago

Hello @essy16, I believe these two issues have been assigned to Harsh, not you. If Harsh hasn't provided me with an update on his progress or allowed me to merge the code, I will proceed with merging it. By the way, I have some advice for you, always check if a particular issue has been assigned to you before working on it. Focus on the issues specifically assigned to you, and if you're interested in working on a different issue, you can comment on that specific issue to request its assignment to yourself, especially if the previous contributor is inactive.

essy16 commented 1 year ago

Hello @Suryansh1720001 I'm sorry I didn't know ...I usually think that when there is an open issue any one is free to work on that issue but it's ok I've learnt my mistake and I won't be doing so again

Vaibhav2002 commented 1 year ago

Hello @Suryansh1720001 I'm sorry I didn't know ...I usually think that when there is an open issue any one is free to work on that issue but it's ok I've learnt my mistake and I won't be doing so again

You can start working on different issues for the time being. Refactoring the UI Layer might be a good start. Will keep this PR open, if the person assigned, does not complete or any other factor arises, we will continue with this PR. You may fix the issue which is causing the build CI to fail

essy16 commented 1 year ago

Do you have suggestions of which issues I can work on?

Vaibhav2002 commented 1 year ago

Do you have suggestions of which issues I can work on?

As you can see, the Ui layer is quite messed up, everything is being done in Activity files, Refactoring that would be a great contribution. You can even add Navigation Components and change all Activities to Fragments to make it even better. Feel free to create an issue and explain your idea and process of implementing this. Will assign it to you

essy16 commented 1 year ago

Hello @Suryansh1720001 Did Harsh create the PR?