Rewrite this - Githubissues

Susannova / Discord_Bot

A configurable discord bot that can run on multiple servers simultaneously.

MIT License

2 stars 1 forks source link

Rewrite this #115

Closed Susannova closed 4 years ago

Susannova commented 4 years ago

https://github.com/Susannova/Discord_Bot/blob/4c5dd64e05caeee7cfccf847fab642eb6694d708/cogs/cog_utility.py#L28

Works only on our server:

https://github.com/Susannova/Discord_Bot/blob/4c5dd64e05caeee7cfccf847fab642eb6694d708/cogs/cog_utility.py#L42

Unnecessary complicated(?) or just not nice

https://github.com/Susannova/Discord_Bot/blob/4c5dd64e05caeee7cfccf847fab642eb6694d708/cogs/cog_utility.py#L30 discord.user should be enough
https://github.com/Susannova/Discord_Bot/blob/4c5dd64e05caeee7cfccf847fab642eb6694d708/cogs/cog_utility.py#L34 := voice.channel.members
https://github.com/Susannova/Discord_Bot/blob/4c5dd64e05caeee7cfccf847fab642eb6694d708/cogs/cog_utility.py#L37 Use different arguments for funtion https://github.com/Susannova/Discord_Bot/blob/4c5dd64e05caeee7cfccf847fab642eb6694d708/cogs/cog_utility.py#L46 See above

Use of discord.utils.find instead of better options: