Susannova / Discord_Bot

A configurable discord bot that can run on multiple servers simultaneously.
MIT License
2 stars 1 forks source link

leaderboard command does not work #149

Closed NickWittig closed 3 years ago

NickWittig commented 3 years ago
File "/home/discord/Discord_Bot/riot/cog_riot.py", line 107, in leaderboard
    summoners.sort(key=lambda x: x.rank_values[queue_type], reverse=True)
  File "/home/discord/Discord_Bot/riot/cog_riot.py", line 107, in <lambda>
    summoners.sort(key=lambda x: x.rank_values[queue_type], reverse=True)
KeyError: 'RANKED_SOLO_5x5'

Is the command even needed anymore?

Susannova commented 3 years ago

Some people would like to use leaderboard instead of plot, so yes.

NickWittig commented 3 years ago

This is actually part of a bigger problem. Namely, we do not use the same summoner data in riot and in tasks anymore, which leads to inconsistencies in the data being stored.

NickWittig commented 3 years ago

This is actually part of a bigger problem. Namely, we do not use the same summoner data in riot and in tasks anymore, which leads to inconsistencies in the data being stored.

This was not really the case, but I will look over the summoner changes in cog_tasks as that seems really out of place.