SussexPsychologySoftware / DoggoNogo

Gamified response inhibition reaction time tasks
https://sussexpsychologysoftware.github.io/DoggoNogo/?datapipe=AlXXHjfLwVP3&p=John%20Smith&s=Original%20Study&l1n=60
2 stars 2 forks source link

Change #7

Open DominiqueMakowski opened 5 days ago

DominiqueMakowski commented 5 days ago

In a pilot that completed the game on the 7th, we lost some metadata fields (start, end, and stars/ends of L1):

image

Is it related to some changes? @Max-Lovell

Max-Lovell commented 2 days ago

Just for a single participant?

Max-Lovell commented 2 days ago

nvm found the file - not sure, looking into it now. annoying we lost user agent too. Can I ask if anyone has been testing the code out? e.g. https://osf.io/s9u4d has been given NOT_BROWSER for a few fields - hopefully this was just one of your team testing things out in unity?

DominiqueMakowski commented 2 days ago

wdym by "testing the code out" Unless @BenjaminTribe has been making some tests, I'd assume that the file is from a "true" pilot participant (?)

Max-Lovell commented 2 days ago

We probably need to clear all the confirmed non-participant data from that repo now testing is underway. Did you send the data to another repo? if that's just got participant data in it, would be good to see if you can add me?

BenjaminTribe commented 2 days ago

Ah that probably was me - I forked to add the black/white square in the corner, but didn't change anything around collecting data so presumably would still have saved?

DominiqueMakowski commented 2 days ago

added you to the stufy's osf

DominiqueMakowski commented 2 days ago

can you tell us how to comment off sending data for testing purposes?

Max-Lovell commented 2 days ago

No worries that repo is just default so will always end up a bit messy. But yeah the missing start and end times is worrying. Data is sent on the script that controls the endScreen atm - this line https://github.com/Sussex-Psychology-Software-Team/DoggoNogo/blob/4b80ce21db2f6090cc4200920b048930ad670b6c/Assets/Scripts/End/EndScreen.cs#L62

DominiqueMakowski commented 2 days ago

Ok yes I think the problematic datafile is one from Ben's tests indeed as it doesn't have an associated experimental file (from jspsych), so I'll just delete it from the study OSF

DominiqueMakowski commented 2 days ago

ah wait no my bad there's something else let me investigate

DominiqueMakowski commented 2 days ago

Yeah no it's weird, the participant with the missing metadata for doggo also has a full experiment data (so it's indeed a true pilot)

Max-Lovell commented 2 days ago

Either way we need to know why it's missing for just one person. They have the url vars set fine (meaning it was an in-browser run, not in unity editor), but the fields relating to timing are all missing in metadata. The datetime for trials are in there, so it's not a problem with access to that function. The metadata datetime fields are also called all over the place, and all are missing, making it tricky to narrow down why. Hopefully we can replicate the bug somehow, but I'm a little stumped atm. There's a possibility it was a bug created during a small change at some point that it fixed now.

Also, there was a legacy bug where startL1 was being overwritten at the start of each level - these are incorrect in the pilot.'ve now called startL1 when participants press the spacebar to move on from the wooden sign instructions. I'm also going to suggest adding 'start' and 'end' date-time fields to each trial, and removing the current 'datetime' field (which tracks end time)? Consistent with metadata and potentially useful info, easy to add in.

DominiqueMakowski commented 2 days ago

@BenjaminTribe could you run the experiment again to collect data with on the latest version? Thanks!

I'm also going to suggest adding 'start' and 'end' date-time fields to each trial, and removing the current 'datetime' field (which tracks end time)? Consistent with metadata and potentially useful info, easy to add in.

okay, I like consistency. Does end for trial refer to the participant's response or the beginning of the next trial?

Max-Lovell commented 2 days ago

Don't worry about this - figured out the issue.

End will be the datetime the trial is saved

DominiqueMakowski commented 2 days ago

Don't worry about this - figured out the issue.

👍

End will be the datetime the trial is saved

which happens when?

Max-Lovell commented 2 days ago

Response given -> data processed -> data saved. During data saving an 'end' field is automatically filled out. A new trial will then begin, although not explicitly in an async manner or anything.

Max-Lovell commented 2 days ago

James has informed me a little refactor will be in order to properly sort this out and ensure things go smooth in future, be a day or two on this one. Are you currently collecting data?

DominiqueMakowski commented 2 days ago

nope still waiting for the ethics -_-

DominiqueMakowski commented 2 days ago

what do you plan on refactoring?

DominiqueMakowski commented 2 days ago

While you're at it, consider renaming the Assets/Sausage/ folder for Assets/Stimulus/ :p

Max-Lovell commented 2 days ago

How the data is handled into a Model-View-Controller design pattern. Will rename sausage to stim 👍

DominiqueMakowski commented 2 days ago

how the data is handled into a Model-View-Controller design pattern

Max-Lovell commented 2 days ago

You ask like I know

Max-Lovell commented 2 days ago

I kind of like having a sausage class too