Make counters dynamic - Githubissues

Sustaingineering / Pump-Firmware

Particle Electron and ESP32 firmware that collects data from sensors and sends it via peer-to-peer LoRa and Particle GSM. The data is recorded on a micro SD card with timestamps.

3 stars 2 forks source link

Make counters dynamic #68

Closed tarek20501 closed 3 years ago

tarek20501 commented 4 years ago

6 counters are hard coded and declared on the stack in main.cpp. Please make the allocation of those counters dynamic. Also make sure your implementation is parametrized such that I can change the numbers of counters easily.

Deadline: Jan 30th meeting

tarek20501 commented 3 years ago

Thanks for the work you did here @jack5661

Just a couple of improvement came to mind when I was using your solution:

Move createCounters function to Counter class as a static method to make main.cpp cleaner
we can use COUNTERS in PinConfig to determine the number of counters instead of another constant