search

Sustainsys / Saml2

Saml2 Authentication services for ASP.NET
Other
961 stars 604 forks source link

Break out Metadata to separate library #1182

Closed rpmansion closed 4 years ago

rpmansion commented 4 years ago

Move metadata codes from Sustainsys.Saml2 to Sustainsys.Saml2.Metadata project except for codes related to loader and scheduler.

rpmansion commented 4 years ago

@AndersAbel should we use the EntityId from IdentityModel? If yes, will remove the one in the code base.

AndersAbel commented 4 years ago

@AndersAbel should we use the EntityId from IdentityModel? If yes, will remove the one in the code base.

What assembly is it in?

rpmansion commented 4 years ago

What assembly is it in?

There is one in System.IdentityModel and one in Sustainsys.Saml2.Metadata

AndersAbel commented 4 years ago

What assembly is it in?

There is one in System.IdentityModel and one in Sustainsys.Saml2.Metadata

As far as I know the one in System.IdentityModel is not available in .NET Core. That's the reason we created an own one.

rpmansion commented 4 years ago

As far as I know the one in System.IdentityModel is not available in .NET Core. That's the reason we created an own one.

I see. Upon checking again, still not available in .NET Core

rpmansion commented 4 years ago

@AndersAbel need to rerun the action, I'm getting all of the test as passed on my local

AndersAbel commented 4 years ago

Ignore it, the report says "internal error". I hope the next commit will work.

rpmansion commented 4 years ago

@AndersAbel I've moved codes of the metadata except the loader and scheduler

AndersAbel commented 4 years ago

@rpmansion Sounds great. I'll have a look and get it merged.

rpmansion commented 4 years ago

@AndersAbel reviewing the code base, what is the reason why we do not maximize the use of System.Security.Cryptography.Xml instead of creating our own classes that are already exist in such library?

AndersAbel commented 4 years ago

@AndersAbel reviewing the code base, what is the reason why we do not maximize the use of System.Security.Cryptography.Xml instead of creating our own classes that are already exist in such library?

Do you have an example? I can think of two reasons: 1. It was not available on .NET Core when the port was done. 2. It doesn't contain all the properties to properly represent the metadata.

AndersAbel commented 4 years ago

Good first step to breaking metadata out to a separate library. Thanks!

rpmansion commented 4 years ago

Linking #1181 issue. @AndersAbel Thank you for merging, will further add new changes. :)