search

Sustainsys / Saml2

Saml2 Authentication services for ASP.NET
Other
952 stars 600 forks source link

Case insensitivity on ModulePath #1280

Closed ghost1face closed 2 years ago

ghost1face commented 3 years ago

This is a pull request targeting branch v2 for Framework & Core2 implementations.

This resolves the issue of the Saml2 handler only listening for requests that start with the case sensitive module path. This allows for case insensitivity resolving #570

This COULD potentially be breaking if current consumers rely on the path to be exact case. If this is a large concern, I'm open to providing a parameter on SPOptions which defines if comparisons should be sensitive or not with a default of case-sensitive comparisons

AndersAbel commented 2 years ago

v3/develop won't have this bug, but no more non-criticial fixes are accepted to v2