Add bugsnag to named notifiers.

Sutto / rocket_pants

API building tools on top of ActionController. Also, an awesome name.

MIT License

981 stars 130 forks source link

Add bugsnag to named notifiers. #127

Closed DamirSvrtan closed 9 years ago

DamirSvrtan commented 9 years ago

I've added two things:

Bugsnag as a named notifier
specs for testing code that gets processed in the named notifier mainly through mocks.

Please give feedback for further necessary steps, I would love if this could get merged.

Sutto commented 9 years ago

Hey there - awesome, work! Especially on the tests :)

Would it be possible to get it to include Bugsnag::Rails::ControllerMethods and call notify_bugsnag instead? That has the advantage of making it play nicer with the rails stuff and should make it pretty straight forward to use. With that, I'd be more than happy to merge in and release a new version.

DamirSvrtan commented 9 years ago

Changed!

DamirSvrtan commented 9 years ago

Hey @Sutto, when will this change be released?

Sutto commented 9 years ago

Was waiting until we had some more changes for a new version, will look into it now.

Sutto commented 9 years ago

Released!