search

Suwayomi / Suwayomi-JUI

A Suwayomi-Server client built in Compose Multiplatform
Mozilla Public License 2.0
414 stars 26 forks source link

Publish to Windows Package Managar (WinGet) #56

Closed vedantmgoyal9 closed 2 years ago

vedantmgoyal9 commented 2 years ago

This action automatically generates manifests for WinGet Community Repository (microsoft/winget-pkgs) and submits them.

Before merging this:

  1. Please add a GitHub token with public_repo scope as a repository secret and rename the secret name in the workflow.
  2. Fork microsoft/winget-pkgs under @Suwayomi.
Syer10 commented 2 years ago

Cant create a secret with the prefix GITHUB_, it seems its reserved

vedantmgoyal9 commented 2 years ago

You can keep it whatever you want and I'll update it in all PRs.

Syer10 commented 2 years ago

I think keep GITHUB_TOKEN like it was since it doesnt need to be changed since its only releasing to the current repo, and name the secret WINGET_PUBLISH_KEY or something similar

vedantmgoyal9 commented 2 years ago

Releases have to be made using a PAT because of:

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

Syer10 commented 2 years ago

Huh, ok. Then just rename them WINGET_PUBLISH_PAT or something similar and I'll merge it 👍

vedantmgoyal9 commented 2 years ago

Done. Good to go 🚀 :)