Suwayomi / Suwayomi-Server

A rewrite of Tachiyomi for the Desktop
Mozilla Public License 2.0
4.03k stars 205 forks source link

[Bug] Tray icon is not reliable #892

Open TyrantRC opened 7 months ago

TyrantRC commented 7 months ago

Device information

Steps to reproduce

  1. start suwayomi server
  2. close the server
  3. start it again

Expected behavior

Should open a tray icon every time I start the server

Actual behavior

It starts the server, opens the webclient, but doesn't show the tray icon that gives you the option to close the server, even though the settings is set to true in the webui and in the sever.conf file

Other details

As far as I see, this happens however I choose to start the server, but I usually start it from the "Suwayomi Launcher.bat" by clicking "Launch" instead of "Electron" in the "Suwayomi-Server Launcher" from a portable folder where I have the uncompressed .zip for this version (I:\Portable Software\Suwayomi-Server-v1.0.0-r1498-windows-x64).

The tray icon comes back if I go to "Settings">"Server">"Show icon in system tray" and disable and reenable it. Although sometimes it might take a while for the tray icon to come back (maximum 1 min).

Someone suggested in a question thread I made that it might have to do with using custom folders, so I tried using the default data folder in %localappdata%\Tachidesk but the issue persisted ―this was done for both the download and data directory.

application.log for the specific moment I started the server and the tray icon didn't appear

AbandonedCart commented 7 months ago

Edit: I was using 0.7.0 on Mac and the tray icon appeared to work, but it started needing to be disabled and enabled again after the upgrade to 1.0.0. I found that somehow the option to disable the tray icon was written to my configuration and that was overriding even the command arguments. Once I set that to true it worked.

TyrantRC commented 7 months ago

@AbandonedCart that's a good point, I was however using "v0.7.0-r1472-x64" for windows and the issue was present back then. So I'm not sure if it differs from versions, platforms, or if it's just something that happens because of something related to settings as you said.

AbandonedCart commented 7 months ago

@TyrantRC Don't worry, I wasn't expecting you to have a solution. It can make a huge difference in debugging to know that an issue is happening on more than one platform, especially if one didn't start having it until later.

zjDrummond commented 7 months ago

Having a similar issue. My system tray icon does appear at the launching of the server app, but goes away later. I'll return to the PC later in the day, and it's gone. The server is still accessible via the browser though, so it's still running.