Suwayomi / Tachidesk-Sorayomi

A free and open source manga reader app to read manga from a Tachidesk-Server instance.
https://suwayomi.github.io/Tachidesk-Sorayomi/
Mozilla Public License 2.0
863 stars 64 forks source link

WebUI doesn't set base url as server #223

Closed KiriKira closed 1 year ago

KiriKira commented 1 year ago

PLEASE READ THIS

I acknowledge that:

Note that the issue will be automatically closed if you do not fill out the title or requested information.

DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT


Describe the bug WebUI doesn't set base url as server as described in https://github.com/Suwayomi/Tachidesk-Sorayomi/issues/60

To Reproduce Steps to reproduce the behavior:

  1. run tachidesk-server via docker with latest image
  2. set server.webUIFlavor = "Custom" in server.conf
  3. put sorayomi web 0.5.10 in webUI directory
  4. open the web, and the server is defaultly set to 127.0.0.1:4567

Expected behavior set server to base url, if detect base url is using http or https via normal port 80/443, disable port setting.

Screenshots image

Device information (Server)

DattatreyaReddy commented 1 year ago

i'll implement this feature for the next release.

DattatreyaReddy commented 1 year ago

Now Server Port will be disabled by default for the web.

Sorayomi will take the Browser origin URL as server URL in web for Ex:

URL = http://nas:4569/#/more is the URL then http://nas:4569 will be the server URL by default

you can change these settings BTW.(Changes will be released in next version)