search

Suwayomi / docker-tachidesk

Run Suwayomi-Server in a docker container
Mozilla Public License 2.0
267 stars 57 forks source link

Java 11 base image #104

Closed renjfk closed 2 weeks ago

renjfk commented 2 months ago

Hi,

Is there any reason why the base image is Java 11? The latest Java LTS is Java 21 and it outperforms Java 11 in every aspect so it's a bit wasteful for it to be Java 11.

Syer10 commented 2 months ago

I haven't gotten around to updating the base image, as long as the PR tests pass it would likely work out of the box though

renjfk commented 2 months ago

This is probably out of context, but even though the project is scaled really small, it would be much better if the container image was built with Jib, as it integrates perfectly with Gradle and outputs really optimized images (e.g. almost half the size compared to what Docker builds) for Java applications.

Syer10 commented 2 weeks ago

I've updated the base image to 21. I've also taken a look at Jib, I think I will have to pass on it. We use a bunch of docker configuration parameters and Jib seems to be limiting in that aspect.