search

Suyious / purrr.frontend

Frontend for Purrr - Chat Application that connects randomly among online users
https://purrr.chat
1 stars 2 forks source link

Onboarding: Ask and show gender to users #11

Closed HarshNarayanJha closed 2 months ago

HarshNarayanJha commented 2 months ago

This PR adds a select to ask the user for their gender and extends socket events to send and receive gender information, which is shown on the chat page besides the partner's name.

I will also open a supporting PR on the backend's repo

Closes #4

netlify[bot] commented 2 months ago

Deploy request for purrrchat rejected.

Name Link
Latest commit 39075a84a9a1d54a132abb53e08e4c310cddc4dd
Suyious commented 2 months ago

@HarshNarayanJha You are requested to please refrain from pushing to master. Your efforts are appreciated. I have looked at your changes and we might integrate it once the actual gender filter functionality has been established.

Note: Please look into why we are not supposed to push to master in case you are a beginner. Short story: If the master in the original doesn't match the master in your fork, we might have serious conflicts. Hope that's clear.

HarshNarayanJha commented 2 months ago

Thanks! Right, sorry about that, I was about to make a new branch but forgot before opening the PR 😢. I will take care of that issue the next time.

Though, are you referring to my master branch or upstream's master branch?

Suyious commented 2 months ago

The pull request should look something like this: Suyious:master from HarshNarayanJha:feature-branch

I hope this makes it clear for you. I was referring to not create a pull request from the master in your fork.

PS: I was referring to the master in your fork. Do not push to it.

HarshNarayanJha commented 2 months ago

Closing