search

Suzhou-Tongyuan / ObjectOriented.jl

Conventional object-oriented programming in Julia without breaking Julia's core design ideas
MIT License
88 stars 6 forks source link

Conform with style-guide #3

Closed PallHaraldsson closed 2 years ago

PallHaraldsson commented 2 years ago

[skip ci]

PallHaraldsson commented 2 years ago

I don't know if any style-guide promotes your style, but if it's your style, or just a misunderstanding, then consider conforming to: https://github.com/SciML/SciMLStyle#struct-type-annotations

Most or all style guides prefer spaces around operators (with some exceptions see there), and that's how they do.

thautwarm commented 2 years ago

It's good. I have some taste for this (I used to write lots of Haskell), but I don't insist on this. I should use style compatible to formatters, and your PR is good.

PallHaraldsson commented 2 years ago

Just note it's not a complete change, I see now, also unchanged in the README (and maybe elsewhere, the ANN post?).

I don't know enough Haskell, to know why it prefers spaces for :: (or even if it means the same there): https://github.com/tibbe/haskell-style-guide/blob/master/haskell-style.md