Suzie1 / ComfyUI_Comfyroll_CustomNodes

Custom nodes for SDXL and SD1.5 including Multi-ControlNet, LoRA, Aspect Ratio, Process Switches, and many more nodes.
https://civitai.com/models/183551/comfyui-comfyroll-custom-nodes
681 stars 89 forks source link

Consider implementing show_help feature as the yellow question mark in the corner like KJ #173

Open Shadetail opened 5 months ago

Shadetail commented 5 months ago

image Notice in the screenshot above how KJ Nodes handle the help feature with a yellow question mark in the corner, which when clicked creates the small popup you can see to the right of the node. I find this to be a much better implementation, so I recommend switching to this system instead.

This makes the help available with a single mouse click, with clickable links immediately available as well, rather than requiring users to connect the output to a node of their choice that shows text (I use ShowText|pysssss) and running the workflow to find the link, and then copying the link into web browser URL bar.

Another benefit is the size taken up by the node. Notice in the screenshot how "CR Prompt Text" has a an exceedingly large header in order to support the show_help output, which results in less space for the actual text, compared to "Clip Text Encode (Prompt)" node next to it. This is even more pronounced when fitting small nodes inside of workflows, where this for example makes the small node such as "CR Seed" considerably larger than the "Seed Everywhere" node that I placed next to it for comparison. With the yellow exclamation mark approach, those nodes could be of the same size. I know that nodes can be collapsed to save space, but that's often inconvenient or reduces usability.

While I understand this could be considered a feature request rather than an issue, for me personally show_help making the node headers larger than they need to be was enough of an issue that I found myself looking for a way to hack the show_help feature out of my local install, but haven't found a reasonable way to do it.